fix: read codebase conventions during new-project for brownfield projects#935
Open
amanape wants to merge 2 commits intogsd-build:mainfrom
Open
fix: read codebase conventions during new-project for brownfield projects#935amanape wants to merge 2 commits intogsd-build:mainfrom
amanape wants to merge 2 commits intogsd-build:mainfrom
Conversation
This was referenced Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Read
.planning/codebase/CONVENTIONS.mdduring/gsd:new-projectquestioning (Step 3) and PROJECT.md creation (Step 4) for brownfield projects.Why
Brownfield projects have conventions already documented but new-project never reads them — leading to redundant questions (e.g., "where should modules live?" when conventions already specify
/lib).Details
has_codebase_mapis true, read CONVENTIONS.md before opening the conversationhas_codebase_map— zero cost for greenfield projectsPros: Fixes the root cause at the earliest decision point. Prevents redundant questions.
Cons: Adds context to orchestrator window during questioning. Only helps if
/gsd:map-codebasewas run first (expected brownfield flow).Related: #936 (planner agent), #937 (phase prompt template) — together these ensure CONVENTIONS.md flows through questioning → planning → execution.
Testing
Checklist
Breaking Changes
None