fix: feed codebase conventions to planner agent for brownfield projects#936
Open
amanape wants to merge 1 commit intogsd-build:mainfrom
Open
fix: feed codebase conventions to planner agent for brownfield projects#936amanape wants to merge 1 commit intogsd-build:mainfrom
amanape wants to merge 1 commit intogsd-build:mainfrom
Conversation
This was referenced Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Feed
.planning/codebase/CONVENTIONS.mdto the planner agent during/gsd:plan-phasefor brownfield projects.Why
The planner creates PLAN.md files without knowledge of existing conventions — plans may specify wrong directories or ignore established patterns. This is critical because
/gsd:discuss-phase(which does read conventions) is optional.Details
has_codebase_maptocmdInitPlanPhaseresulthas_codebase_mapfrom init; conditionally add<codebase_context>with CONVENTIONS.md to planner prompt<planning_context>Pros: Safety net when discuss-phase is skipped. Plans reference established patterns. Conditional — zero cost for greenfield.
Cons: Adds one file to planner context. Partial overlap with discuss-phase's codebase scout (but discuss-phase is optional).
Related: #935 (new-project questioning), #937 (phase prompt template) — together these ensure CONVENTIONS.md flows through questioning → planning → execution.
Testing
Checklist
Breaking Changes
None