fix: add codebase conventions to phase prompt template for brownfield executors#937
Open
amanape wants to merge 1 commit intogsd-build:mainfrom
Open
fix: add codebase conventions to phase prompt template for brownfield executors#937amanape wants to merge 1 commit intogsd-build:mainfrom
amanape wants to merge 1 commit intogsd-build:mainfrom
Conversation
This was referenced Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add conditional
.planning/codebase/CONVENTIONS.mdreference to the phase prompt template's<context>section for brownfield projects.Why
The executor agent that runs PLAN.md files never sees codebase conventions — it may violate existing coding patterns during implementation. This is the last line of defense after questioning (#935) and planning (#936).
Details
<context>sectionFollows the template's existing pattern for conditional context (commented with
# If .planning/codebase/ exists).Pros: Last backstop — even if planning misses conventions, executor sees them. Minimal change (3 lines each in template + docs).
Cons: Lowest impact of the three PRs — if planner already respects conventions, executor inherits through well-written tasks. Template comments are guidance for the planner, not enforced.
Related: #935 (new-project questioning), #936 (planner agent) — together these ensure CONVENTIONS.md flows through questioning → planning → execution.
Testing
Checklist
Breaking Changes
None