Migrate to Instant from Date

[Sorikoff]

This supports recent major overhaul of code by replacing legacy Date with modern date and time API (Instant in this case). Older Android versions are supported with help of Java 8 desugaring.

[Jawnnypoo]

Nice! We would want to really make sure this works with pre-23 devices before shipping, since I have seen cases where the code will compile and show no issues, but then when you get it on an actual device, it crashes at runtime.

[Jawnnypoo]

This shouldn't be needed.

[Sorikoff]

Hm, I looked here. Do you know if it is wrong?

[Jawnnypoo]

Ah I see! I forgot this project was using minSdk 14. It should probably be bumped to 21 😅

[Jawnnypoo]

This is a pretty large API change that affects all downstream users, so @kaushikgopal would need to really think about if this is worth the "breaking" change. I do like the benefits that Instant brings, and this might be the best opportunity to change over, with a 4.0 release.

[kaushikgopal]

thanks @Sorikoff thank you for the PR 🙏🏽 . some initial thoughts:

1. multiDexEnabled & minSdk 14 - also cc @Jawnnypoo . I'm torn. I feel there might be many users out there wanting to use TrueTime with a lower SDK. Being a library, I wonder if we should be conservative and keep it. If anything, with the removal of Rx I wonder if we can push this even back.
2. To Jawnny's point, I do worry that most folks haven't switched to Instant as being the default. For better or worse Date is the defacto usage 🫤. We wouldn't want people to import TrueTime and go through hoops to get the basic usage going.

Curious what you folks think

[Sorikoff]

@kaushikgopal 👋
Desugaring is available for 2+ years already, I think. And some solutions exist for even longer time... so with this major update it might be the right time to migrate 🤔

[Ke911]

Hh

[Ke911]

Vbdbjjdbjjsv I

[kaushikgopal]

I actually like tbr desugaring solution 🤔. Not to mention Kotlin provides a bunch of solutions too as part of their time library. I can revisit this again.