Wrap anonymous routines when they contain any sections#254
Closed
zaneduffield wants to merge 3 commits intointegrated-application-development:masterfrom
Closed
Wrap anonymous routines when they contain any sections#254zaneduffield wants to merge 3 commits intointegrated-application-development:masterfrom
zaneduffield wants to merge 3 commits intointegrated-application-development:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
zaneduffield
force-pushed
the
no-inline-anon-proc-with-sections
branch
from
66a2cd7 to
db634d0
Compare
jgardn3r
requested changes
Aug 19, 2025
Collaborator
jgardn3r
left a comment
jgardn3r
left a comment
There was a problem hiding this comment.
Resolve your merge conflicts and update the wording and I think we are good to go.
This was referenced Aug 20, 2025
Collaborator
Author
|
Superseded by #268. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to #241, but doesn't exactly address the issue there.
When thinking about that issue, I realised that it's probably a bad idea to try to format anonymous routines with sections inline in the first place. In making that change, I found and fixed a bug specifically with
typesections in anonymous routines.