Skip to content

Restructure child lines for anonymous routine sections#268

Merged
zaneduffield merged 5 commits intointegrated-application-development:masterfrom
zaneduffield:anon-section-child-line-restructure
Aug 24, 2025
Merged

Restructure child lines for anonymous routine sections#268
zaneduffield merged 5 commits intointegrated-application-development:masterfrom
zaneduffield:anon-section-child-line-restructure

Conversation

@zaneduffield
Copy link
Collaborator

@zaneduffield zaneduffield commented Aug 22, 2025

  • Remove dead code in optimising_line_formatter
  • Parse child lines with no implicit level increment
  • Convert anonymous routine section headers to child lines
  • Ensure starting continuation is correctly set for child lines
  • Remove redundant code after child line restructure

Fixes #241, and supersedes #254.

@zaneduffield zaneduffield requested a review from jgardn3r August 22, 2025 06:27
@codecov
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

jgardn3r
jgardn3r previously approved these changes Aug 24, 2025
Copy link
Collaborator

@jgardn3r jgardn3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're happy with my changes, I'm happy with it all. You can also close the other PR.

zaneduffield and others added 3 commits August 25, 2025 09:08
Previously these headers would be in the parent line, and the lines
within the section would be children of the header (e.g.
var/const/type). With this change, every line in between the end of the
anonymous routine parameter list and the `begin` for the routine are
parsed as child lines of the initial `procedure` or `keyword` token.
@zaneduffield
Copy link
Collaborator Author

I realised I could simplify one of the changes slightly.

@zaneduffield zaneduffield requested a review from jgardn3r August 24, 2025 23:09
@zaneduffield zaneduffield merged commit 83fb55a into integrated-application-development:master Aug 24, 2025
7 checks passed
@zaneduffield zaneduffield deleted the anon-section-child-line-restructure branch August 24, 2025 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect formatting of sections inside short anonymous routines with forced breaks

2 participants