Conversation
…mented some very verbose debug logs (should create a new level: UVERBOSE or UTRACE)
…t", "Mem/FlannIndexSaved", "Kp/SerializeWithChecksum".
…ces with new parameters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is improving loading time of a database, by:
Kp/FlannIndexSavedcan be used to save the FLANN index to the database. This implements the idea from this comment: Need for speed - Speed up loading map time #1267 (comment). It makes reloading the dictionary super fast. We added multiple checks in case the dictionary changed for any reasons (dictionary parameters changed, words have been added/removed incrementally to dictionary...). Also in contrast to Need for speed - Speed up loading map time #1267, we avoid saving again the descriptors. Currently this feature can be enabled only in localization mode.Mem/LoadVisualLocalFeaturesOnInitcan be disabled to avoid loading all visual features in RAM on start. This saves significantly time to load database. The features are loaded on RAM only "on-demand", i.e., only when a loop closure transformation is required. One caveat is that it may makeRGBD/LocalBundleOnLoopClosurenot working properly.map_cache_loaded_on_inittortabmapnode (commit for ROS1 introlab/rtabmap_ros@ca4d331). Similarly toMem/LoadVisualLocalFeaturesOnInit, ifmap_cache_loaded_on_initis false, we also don't load immediately all local grids in RAM. This saves time on initialization and when switching maps (load_databaseservice). Note that in localization mode where the global optimized map doesn't change, it may also save significant RAM. However, as soon as the global occupancy grid needs to be updated/re-assembled, all local grids may be reloaded. So if we expect that the global occupancy grid will be re-optimized, it is better to keep the old behavior by loading all local grids in RAM at the beginning, to avoid big lag in the middle of operation.