Skip to content

Potential fix for code scanning alert no. 10: Code injection #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
juancarlosjr97 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Potential fix for code scanning alert no. 10: Code injection #158

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,12 @@ jobs:
steps:
- id: release_options
name: Release options
env:
Copy link

Copilot AI May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Add a brief comment above this line explaining that assigning to HEAD_BRANCH prevents shell injection by treating the input as a literal.

Suggested change
env:
env:
# Assigning to HEAD_BRANCH prevents shell injection by treating the input as a literal.

Copilot uses AI. Check for mistakes.
HEAD_BRANCH: ${{ github.event.workflow_run.head_branch }}
run: |
release_options="--git.tagExclude='*[-]*'"

branch=${{ github.event.workflow_run.head_branch }}
branch="$HEAD_BRANCH"

if [ -n "$branch" ] && [ "$branch" = "develop" ]; then
Comment on lines +23 to 25
Copy link

Copilot AI May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] You can simplify this step by using $HEAD_BRANCH directly in the conditional checks and remove the extra branch variable to reduce redundancy.

Suggested change
branch="$HEAD_BRANCH"
if [ -n "$branch" ] && [ "$branch" = "develop" ]; then
if [ -n "$HEAD_BRANCH" ] && [ "$HEAD_BRANCH" = "develop" ]; then

Copilot uses AI. Check for mistakes.
release_options="--preRelease=beta"
Expand Down