e2e: Aligns Immutable Fields Across Curl Manifests#13444
Merged
npolshakova merged 1 commit intokgateway-dev:mainfrom Feb 4, 2026
Merged
e2e: Aligns Immutable Fields Across Curl Manifests#13444npolshakova merged 1 commit intokgateway-dev:mainfrom
npolshakova merged 1 commit intokgateway-dev:mainfrom
Conversation
Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
gateway-bot
added
kind/cleanup
jenshu
reviewed
Jan 30, 2026
| metadata: | ||
| name: curl | ||
| --- | ||
| # Immutable pod spec fields should be consistent with test/e2e/defaults/testdata/curl_pod.yaml |
Contributor
There was a problem hiding this comment.
if so many tests are using the same curl pod, can we have all the tests use the default one (test/e2e/defaults/testdata/curl_pod.yaml) instead of redefining it in each test manifest?
although not sure if it's worth the refactor if we will replace it soon (see #13053)
Contributor
Author
There was a problem hiding this comment.
@jenshu that's where I first started with https://github.com/danehans/kgateway/tree/issue_13408 but several tests have necessary deviations from test/e2e/defaults/testdata/curl_pod.yaml. +1 on #13053 being the best long-term solution.
npolshakova
approved these changes
Feb 2, 2026
jenshu
approved these changes
Feb 2, 2026
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 2, 2026
Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
howardjohn
pushed a commit
to howardjohn/kgateway
that referenced
this pull request
Feb 10, 2026
Signed-off-by: Daneyon Hansen <daneyon.hansen@solo.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Aligns immutable fields across curl manifests in e2e tests.
Fixes #13408
Change Type
/kind cleanup
Changelog
Additional Notes
N/A