Skip to content

e2e: Aligns Immutable Fields Across Curl Manifests #13444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
npolshakova merged 1 commit into from
Feb 4, 2026
Merged

e2e: Aligns Immutable Fields Across Curl Manifests #13444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions test/e2e/defaults/testdata/curl_pod.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ kind: Namespace
metadata:
name: curl
---
# Immutable pod spec fields should be consistent with feature-specific curl manifests
# due to https://github.com/kgateway-dev/kgateway/issues/13408.
apiVersion: v1
kind: Pod
metadata:
Expand Down
4 changes: 4 additions & 0 deletions test/e2e/features/inferenceextension/testdata/curl_pod.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ kind: Namespace
metadata:
name: curl
---
# Immutable pod spec fields should be consistent with test/e2e/defaults/testdata/curl_pod.yaml
Copy link
Contributor

@jenshu jenshu Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if so many tests are using the same curl pod, can we have all the tests use the default one (test/e2e/defaults/testdata/curl_pod.yaml) instead of redefining it in each test manifest?

although not sure if it's worth the refactor if we will replace it soon (see #13053)

Copy link
Contributor Author

@danehans danehans Jan 30, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jenshu that's where I first started with https://github.com/danehans/kgateway/tree/issue_13408 but several tests have necessary deviations from test/e2e/defaults/testdata/curl_pod.yaml. +1 on #13053 being the best long-term solution.

# due to https://github.com/kgateway-dev/kgateway/issues/13408.
apiVersion: v1
kind: Pod
metadata:
Expand All @@ -28,5 +30,7 @@ spec:
resources:
requests:
cpu: "100m"
memory: "64Mi"
limits:
cpu: "200m"
memory: "128Mi"
7 changes: 6 additions & 1 deletion test/e2e/features/istio/testdata/setup.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,8 @@ kind: Namespace
metadata:
name: curl
---
# Immutable pod spec fields should be consistent with test/e2e/defaults/testdata/curl_pod.yaml
# due to https://github.com/kgateway-dev/kgateway/issues/13408.
apiVersion: v1
kind: Pod
metadata:
Expand All @@ -79,6 +81,7 @@ metadata:
app: curl
version: v1
spec:
terminationGracePeriodSeconds: 0
containers:
- name: curl
image: ghcr.io/kgateway-dev/curl:7.83.1
Expand All @@ -90,5 +93,7 @@ spec:
resources:
requests:
cpu: "100m"
memory: "64Mi"
limits:
cpu: "200m"
cpu: "200m"
memory: "128Mi"
5 changes: 5 additions & 0 deletions test/e2e/features/listener_policy/testdata/setup.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ kind: Namespace
metadata:
name: curl
---
# Immutable pod spec fields should be consistent with test/e2e/defaults/testdata/curl_pod.yaml
# due to https://github.com/kgateway-dev/kgateway/issues/13408.
apiVersion: v1
kind: Pod
metadata:
Expand All @@ -38,6 +40,7 @@ metadata:
app: curl
version: v1
spec:
terminationGracePeriodSeconds: 0
containers:
- name: curl
image: ghcr.io/kgateway-dev/curl:7.83.1
Expand All @@ -49,5 +52,7 @@ spec:
resources:
requests:
cpu: "100m"
memory: "64Mi"
limits:
cpu: "200m"
memory: "128Mi"
10 changes: 10 additions & 0 deletions test/e2e/features/services/httproute/testdata/route-with-service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ kind: Namespace
metadata:
name: curl
---
# Immutable pod spec fields should be consistent with test/e2e/defaults/testdata/curl_pod.yaml
# due to https://github.com/kgateway-dev/kgateway/issues/13408.
apiVersion: v1
kind: Pod
metadata:
Expand All @@ -40,6 +42,7 @@ metadata:
app: curl
version: v1
spec:
terminationGracePeriodSeconds: 0
containers:
- name: curl
image: ghcr.io/kgateway-dev/curl:7.83.1
Expand All @@ -48,3 +51,10 @@ spec:
- "tail"
- "-f"
- "/dev/null"
resources:
requests:
cpu: "100m"
memory: "64Mi"
limits:
cpu: "200m"
memory: "128Mi"
5 changes: 5 additions & 0 deletions test/e2e/features/services/tcproute/testdata/cross-ns-gateway-and-client.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ spec:
port: 8080
protocol: TCP
---
# Immutable pod spec fields should be consistent with test/e2e/defaults/testdata/curl_pod.yaml
# due to https://github.com/kgateway-dev/kgateway/issues/13408.
apiVersion: v1
kind: Pod
metadata:
Expand All @@ -17,6 +19,7 @@ metadata:
app: curl
version: v1
spec:
terminationGracePeriodSeconds: 0
containers:
- name: curl
image: ghcr.io/kgateway-dev/curl:7.83.1
Expand All @@ -28,5 +31,7 @@ spec:
resources:
requests:
cpu: "100m"
memory: "64Mi"
limits:
cpu: "200m"
memory: "128Mi"
5 changes: 5 additions & 0 deletions test/e2e/features/services/tcproute/testdata/cross-ns-no-refgrant-gateway-and-client.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ spec:
port: 8080
protocol: TCP
---
# Immutable pod spec fields should be consistent with test/e2e/defaults/testdata/curl_pod.yaml
# due to https://github.com/kgateway-dev/kgateway/issues/13408.
apiVersion: v1
kind: Pod
metadata:
Expand All @@ -17,6 +19,7 @@ metadata:
app: curl
version: v1
spec:
terminationGracePeriodSeconds: 0
containers:
- name: curl
image: ghcr.io/kgateway-dev/curl:7.83.1
Expand All @@ -28,5 +31,7 @@ spec:
resources:
requests:
cpu: "100m"
memory: "64Mi"
limits:
cpu: "200m"
memory: "128Mi"
5 changes: 5 additions & 0 deletions test/e2e/features/services/tcproute/testdata/multi-listener-gateway-and-client.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ spec:
kinds:
- kind: TCPRoute
---
# Immutable pod spec fields should be consistent with test/e2e/defaults/testdata/curl_pod.yaml
# due to https://github.com/kgateway-dev/kgateway/issues/13408.
apiVersion: v1
kind: Pod
metadata:
Expand All @@ -26,6 +28,7 @@ metadata:
app: curl
version: v1
spec:
terminationGracePeriodSeconds: 0
containers:
- name: curl
image: ghcr.io/kgateway-dev/curl:7.83.1
Expand All @@ -37,5 +40,7 @@ spec:
resources:
requests:
cpu: "100m"
memory: "64Mi"
limits:
cpu: "200m"
memory: "128Mi"
5 changes: 5 additions & 0 deletions test/e2e/features/services/tcproute/testdata/single-listener-gateway-and-client.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ spec:
kinds:
- kind: TCPRoute
---
# Immutable pod spec fields should be consistent with test/e2e/defaults/testdata/curl_pod.yaml
# due to https://github.com/kgateway-dev/kgateway/issues/13408.
apiVersion: v1
kind: Pod
metadata:
Expand All @@ -20,6 +22,7 @@ metadata:
app: curl
version: v1
spec:
terminationGracePeriodSeconds: 0
containers:
- name: curl
image: ghcr.io/kgateway-dev/curl:7.83.1
Expand All @@ -31,5 +34,7 @@ spec:
resources:
requests:
cpu: "100m"
memory: "64Mi"
limits:
cpu: "200m"
memory: "128Mi"
5 changes: 5 additions & 0 deletions test/e2e/features/services/tcproute/testdata/tls-tcp-gateway-and-client.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ spec:
kinds:
- kind: TCPRoute
---
# Immutable pod spec fields should be consistent with test/e2e/defaults/testdata/curl_pod.yaml
# due to https://github.com/kgateway-dev/kgateway/issues/13408.
apiVersion: v1
kind: Pod
metadata:
Expand All @@ -26,6 +28,7 @@ metadata:
app: curl
version: v1
spec:
terminationGracePeriodSeconds: 0
containers:
- name: curl
image: ghcr.io/kgateway-dev/curl:7.83.1
Expand All @@ -37,8 +40,10 @@ spec:
resources:
requests:
cpu: "100m"
memory: "64Mi"
limits:
cpu: "200m"
memory: "128Mi"
volumeMounts:
- name: server-certs
mountPath: /etc/server-certs
Expand Down
5 changes: 5 additions & 0 deletions test/e2e/features/services/tlsroute/testdata/cross-ns-gateway-and-client.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ spec:
tls:
mode: Passthrough
---
# Immutable pod spec fields should be consistent with test/e2e/defaults/testdata/curl_pod.yaml
# due to https://github.com/kgateway-dev/kgateway/issues/13408.
apiVersion: v1
kind: Pod
metadata:
Expand All @@ -20,6 +22,7 @@ metadata:
app: curl
version: v1
spec:
terminationGracePeriodSeconds: 0
containers:
- name: curl
image: ghcr.io/kgateway-dev/curl:7.83.1
Expand All @@ -31,8 +34,10 @@ spec:
resources:
requests:
cpu: "100m"
memory: "64Mi"
limits:
cpu: "200m"
memory: "128Mi"
volumeMounts:
- name: server-certs
mountPath: /etc/server-certs
Expand Down
5 changes: 5 additions & 0 deletions test/e2e/features/services/tlsroute/testdata/cross-ns-no-refgrant-gateway-and-client.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ spec:
tls:
mode: Passthrough
---
# Immutable pod spec fields should be consistent with test/e2e/defaults/testdata/curl_pod.yaml
# due to https://github.com/kgateway-dev/kgateway/issues/13408.
apiVersion: v1
kind: Pod
metadata:
Expand All @@ -20,6 +22,7 @@ metadata:
app: curl
version: v1
spec:
terminationGracePeriodSeconds: 0
containers:
- name: curl
image: ghcr.io/kgateway-dev/curl:7.83.1
Expand All @@ -31,8 +34,10 @@ spec:
resources:
requests:
cpu: "100m"
memory: "64Mi"
limits:
cpu: "200m"
memory: "128Mi"
volumeMounts:
- name: server-certs
mountPath: /etc/server-certs
Expand Down
5 changes: 5 additions & 0 deletions test/e2e/features/services/tlsroute/testdata/multi-listener-gateway-and-client.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ spec:
kinds:
- kind: TLSRoute
---
# Immutable pod spec fields should be consistent with test/e2e/defaults/testdata/curl_pod.yaml
# due to https://github.com/kgateway-dev/kgateway/issues/13408.
apiVersion: v1
kind: Pod
metadata:
Expand All @@ -32,6 +34,7 @@ metadata:
app: curl
version: v1
spec:
terminationGracePeriodSeconds: 0
containers:
- name: curl
image: ghcr.io/kgateway-dev/curl:7.83.1
Expand All @@ -43,8 +46,10 @@ spec:
resources:
requests:
cpu: "100m"
memory: "64Mi"
limits:
cpu: "200m"
memory: "128Mi"
volumeMounts:
- name: server-certs
mountPath: /etc/server-certs
Expand Down
5 changes: 5 additions & 0 deletions test/e2e/features/services/tlsroute/testdata/single-listener-gateway-and-client.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ spec:
kinds:
- kind: TLSRoute
---
# Immutable pod spec fields should be consistent with test/e2e/defaults/testdata/curl_pod.yaml
# due to https://github.com/kgateway-dev/kgateway/issues/13408.
apiVersion: v1
kind: Pod
metadata:
Expand All @@ -23,6 +25,7 @@ metadata:
app: curl
version: v1
spec:
terminationGracePeriodSeconds: 0
containers:
- name: curl
image: ghcr.io/kgateway-dev/curl:7.83.1
Expand All @@ -34,8 +37,10 @@ spec:
resources:
requests:
cpu: "100m"
memory: "64Mi"
limits:
cpu: "200m"
memory: "128Mi"
volumeMounts:
- name: server-certs
mountPath: /etc/server-certs
Expand Down
8 changes: 8 additions & 0 deletions test/e2e/features/waypoint/testdata/common/test_apps.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ kind: ServiceAccount
metadata:
name: curl
---
# Immutable pod spec fields should be consistent with test/e2e/defaults/testdata/curl_pod.yaml
# due to https://github.com/kgateway-dev/kgateway/issues/13408.
apiVersion: v1
kind: Pod
metadata:
Expand All @@ -27,8 +29,10 @@ spec:
resources:
requests:
cpu: "100m"
memory: "64Mi"
limits:
cpu: "200m"
memory: "128Mi"
---
##################################################################################################
# Notcurl pod - based on the curl pod but with another identity
Expand All @@ -38,6 +42,8 @@ kind: ServiceAccount
metadata:
name: notcurl
---
# Immutable pod spec fields should be consistent with test/e2e/defaults/testdata/curl_pod.yaml
# due to https://github.com/kgateway-dev/kgateway/issues/13408.
apiVersion: v1
kind: Pod
metadata:
Expand All @@ -59,8 +65,10 @@ spec:
resources:
requests:
cpu: "100m"
memory: "64Mi"
limits:
cpu: "200m"
memory: "128Mi"
---

##################################################################################################
Expand Down