Skip to content

Comments

fix pricing tier comparison headers#6138

Closed
krishkumar84 wants to merge 1 commit intolayer5io:masterfrom
krishkumar84:pricing-tier-comparison
Closed

fix pricing tier comparison headers#6138
krishkumar84 wants to merge 1 commit intolayer5io:masterfrom
krishkumar84:pricing-tier-comparison

Conversation

@krishkumar84
Copy link
Contributor

@krishkumar84 krishkumar84 commented Dec 31, 2024

Description

This PR fixes #6122

Notes for Reviewers
@leecalcote @Ajay-singh1 @sudhanshutech @vishalvivekm
kindly review this pr
iIn this PR, I made the pricing component header sticky, allowing the subscription tiers to remain visible throughout the scroll within the component

Uploading layer5.mp4…

Signed commits

  • Yes, I signed my commits.

Signed-off-by: krish <krish221200867@gmail.com>
@l5io
Copy link
Contributor

l5io commented Dec 31, 2024

🚀 Preview for commit 766e6c2 at: https://6773d865644e61242176d16b--layer5.netlify.app

@Ajay-singh1
Copy link
Member

Hey! @krishkumar84 Can you see the margins between the table cell? It doesn't look good.Also can you make it look like this ....

Screencast.from.2024-12-31.18-53-44.mp4

@krishkumar84
Copy link
Contributor Author

krishkumar84 commented Dec 31, 2024

Hi @Ajay-singh1,

I have kept the design simple and aligned with the current site’s layout. The issue is about making the header sticky, which is why I haven't modified the styling of the table, as it is not necessary for this issue for design change we can create another issue ...

@Ajay-singh1
Copy link
Member

Ajay-singh1 commented Dec 31, 2024

Hi @Ajay-singh1,

I have kept the design simple and aligned with the current site’s layout. The issue is about making the header sticky, which is why I haven't modified the styling of the table, as it is not necessary for this issue for design change we can create another issue ...

Making the header sticky can be achieved quiet easily right?.We want the user experience to be good... make the necessary changes else everything is good.

@leecalcote leecalcote requested a review from SAHU-01 December 31, 2024 18:44
@leecalcote
Copy link
Member

Thank you for working on improving the site, gents.

@Ajay-singh1
Copy link
Member

Can't you see the borders?.
Screenshot_20250103-210841_Chrome

@krishkumar84
Copy link
Contributor Author

krishkumar84 commented Jan 3, 2025

hey @Ajay-singh1 can you tell me the exact changes i have to do in this like in border or something

@Ajay-singh1
Copy link
Member

@krishkumar84 Hmm....First you need to fix the borders do you see the black borders around table cells?
Screenshot from 2025-01-03 21-35-10
And make the table header look like this...

Screencast.from.2024-12-31.18-53-44.mp4

@vishalvivekm
Copy link
Contributor

@krishkumar84
Thank you for your contribution!
Let's discuss this during the website call on Monday at 6:30 PM IST

adding it as an agenda item to the meeting minutes.

@leecalcote leecalcote requested a review from Ajay-singh1 January 8, 2025 02:23
@krishkumar84
Copy link
Contributor Author

@krishkumar84 Thank you for your contribution! Let's discuss this during the website call on Monday at 6:30 PM IST

adding it as an agenda item to the meeting minutes.

hey @vishalvivekm @sudhanshutech can we go ahead and merge that PR as we discussed during the website call?

Copy link
Member

@Ajay-singh1 Ajay-singh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krishkumar84 Did you incorporate the changes?

@krishkumar84
Copy link
Contributor Author

@krishkumar84 Did you incorporate the changes?

hey @Ajay-singh1 on the website call @sudhanshutech and others also say ther changes, they will open a separate issue in the repository to address them...

@krishkumar84
Copy link
Contributor Author

hey @leecalcote @Ajay-singh1 @sudhanshutech can we merge this pr as we discussed it in during website call ??

Copy link
Contributor

@vishalvivekm vishalvivekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krishkumar84 Please revert whitespace and lint changes that are not pertinent to the issue.

@stale
Copy link

stale bot commented Apr 26, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Apr 26, 2025
@stale
Copy link

stale bot commented Apr 27, 2025

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

@stale stale bot closed this Apr 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

issue/stale Issue has not had any activity for an extended period of time

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Pricing] Make Tier Comparison Header Sticky

5 participants