New Sistent Card Component#6196
Conversation
Signed-off-by: Anand-Theertha <anandtheerthav3@gmail.com>
|
🚀 Preview for commit cef7f5a at: https://6789dc13b28845a8c5456072--layer5.netlify.app |
|
Please check and let me know if it looks good: @sudhanshutech @Vidit-Kushwaha |
|
@Anand-Theertha adding it as an agenda item to the meeting minutes. |
|
@Vidit-Kushwaha please review. |
Vidit-Kushwaha
left a comment
Vidit-Kushwaha
left a comment
There was a problem hiding this comment.
I have provided some suggestions @Anand-Theertha kindly look into these comment. else look good to me @sudhanshutech any suggestions?
| <Typography variant="h5" component="div"> | ||
| Layer5 | ||
| </Typography> | ||
| <Typography sx={{ color: "#9d9d9d", fontSize: 15, mb: 1.5 }}> |
There was a problem hiding this comment.
Don't use custom colors, font sizes in typography. Kindly look into sistent's theme that we use
| </CardContent> | ||
| </CardActions> | ||
| <CardActions> | ||
| <Button size="small" color="primary" variant="outlined"> |
There was a problem hiding this comment.
| <Button size="small" color="primary" variant="outlined"> | |
| <Button size="small" color="primary" variant="outlined"> |
generally we don't use mui's color prop you can make it default color rather that specifying color as primary
| import { CodeBlock } from "../button/code-block"; | ||
| import { SistentLayout } from "../../sistent-layout"; | ||
|
|
||
| import MesheryLogo from "../../../../../assets/images/meshery/meshery-logo-light-text-side.webp"; |
There was a problem hiding this comment.
If you are using logo make it sure you use for both themes (i.e. light and dark theme)
Signed-off-by: Anand-Theertha <54447234+Anand-Theertha@users.noreply.github.com>
|
🚀 Preview for commit cab7c8f at: https://679368a9e2d580f82a5caa31--layer5.netlify.app |
|
@Anand-Theertha did you get the chance to take a look at @Vidit-Kushwaha 's suggestions ? |
|
Yes @vishalvivekm, will be pushing feedback changes in sometime. |
@Anand-Theertha did you get the time to push the changes? We can discuss your progress on websites call today. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
issue/stale
|
This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue. |
5 participants
Description
This PR fixes #5908. This PR adds a Card component to the Sistent components. Made changes according to the feedback suggested. Following are a few screenshots of how the implementation looks:
Notes for Reviewers
Signed commits