[Python] Add HLMemType and FirMemType bindings to Seq dialect#9585
Merged
[Python] Add HLMemType and FirMemType bindings to Seq dialect#9585
Conversation
uenoku
approved these changes
Feb 5, 2026
Member
uenoku
left a comment
uenoku
left a comment
There was a problem hiding this comment.
The code looks good, so feel free to proceed. Please note that the current fragmentation of memory operations is suboptimal and likely to cause issues down the line (see Issue #5463)
Co-authored-by: Hideto Ueno <uenoku.tokotoko@gmail.com>
Co-authored-by: Hideto Ueno <uenoku.tokotoko@gmail.com>
Contributor
Author
|
Thanks, @uenoku! I appreciate the review and the heads-up about the future unification tracked in Issue #5463. Since the code looks good now, I'll merge this PR shortly. I've also left a comment on Issue #5463 to ensure that the Python bindings are updated (or removed) when the memory types are eventually unified. Cheers! |
Arya-Golkari
pushed a commit
to Arya-Golkari/circt
that referenced
this pull request
Feb 7, 2026
) * [Python] Add HLMemType and FirMemType bindings to Seq dialect * Update include/circt-c/Dialect/Seq.h Co-authored-by: Hideto Ueno <uenoku.tokotoko@gmail.com> * Update include/circt-c/Dialect/Seq.h Co-authored-by: Hideto Ueno <uenoku.tokotoko@gmail.com> --------- Co-authored-by: Hideto Ueno <uenoku.tokotoko@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Python bindings for two missing Seq dialect types
HLMemTypeandFirMemType.Includes C API wrappers and tests.