Skip to content

feat(controller): support endpointslices to replace endpoints#4161

Open
davidcheng0922 wants to merge 1 commit intolonghorn:masterfrom
davidcheng0922:issue-10796-endpointslice
Open

feat(controller): support endpointslices to replace endpoints#4161
davidcheng0922 wants to merge 1 commit intolonghorn:masterfrom
davidcheng0922:issue-10796-endpointslice

Conversation

@davidcheng0922
Copy link
Contributor

Which issue(s) this PR fixes:

longhorn/longhorn#10796

What this PR does / why we need it:

In Kubernetes v1.33, the endpoints resource is deprecated.
This PR updates Longhorn to replace endpoints with endpointslices.

Special notes for your reviewer:

For each ShareManager, there will now be two EndpointSlices:

  1. Kubernetes-managed EndpointSlice
  • Automatically generated by the kubernetes controller
  • Has OwnerReference pointing to the Service
  1. Longhorn-managed EndpointSlice
  • Explicitly created by longhorn-manager
  • Has OwnerReference pointing to the ShareManager

We cannot directly modify the Kubernetes-managed EndpointSlice, since changes will be reverted during reconciliation.
Instead, longhorn-manager creates its own EndpointSlice to support use cases such as Multus.

As a result, a ShareManager Service may have two EndpointSlices. Consumers (e.g., kube-proxy, CNI) will aggregate them into a unified set of endpoints.

Additional documentation or context

https://kubernetes.io/docs/concepts/services-networking/endpoint-slices/

@davidcheng0922 davidcheng0922 requested a review from a team September 30, 2025 06:59
@coderabbitai
Copy link

coderabbitai bot commented Sep 30, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

📝 Customizable high-level summaries are now available!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide custom instructions to shape the summary (bullet lists, tables, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example:

"Create a concise high-level summary as a bullet-point list. Then include a Markdown table showing lines added and removed by each contributing author."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@derekbit
Copy link
Member

@davidcheng0922 Could you resolve the conflict? Thank you.

@davidcheng0922 davidcheng0922 force-pushed the issue-10796-endpointslice branch 2 times, most recently from 529292f to 005eab4 Compare October 17, 2025 02:14
@derekbit derekbit force-pushed the issue-10796-endpointslice branch from 005eab4 to 5a75b3a Compare October 19, 2025 10:31
@derekbit derekbit force-pushed the issue-10796-endpointslice branch 2 times, most recently from 1151353 to 41515f3 Compare November 6, 2025 05:08
Signed-off-by: David Cheng <davidcheng0922@gmail.com>
@derekbit derekbit force-pushed the issue-10796-endpointslice branch from 41515f3 to db264ed Compare November 16, 2025 23:47
@davidcheng0922
Copy link
Contributor Author

Pending

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants