feat(controller): support endpointslices to replace endpoints#4161
feat(controller): support endpointslices to replace endpoints#4161davidcheng0922 wants to merge 1 commit intolonghorn:masterfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
7b6cb23 to
6870a11
Compare
|
@davidcheng0922 Could you resolve the conflict? Thank you. |
529292f to
005eab4
Compare
005eab4 to
5a75b3a
Compare
1151353 to
41515f3
Compare
Signed-off-by: David Cheng <davidcheng0922@gmail.com>
41515f3 to
db264ed
Compare
|
Pending |
Which issue(s) this PR fixes:
longhorn/longhorn#10796
What this PR does / why we need it:
In Kubernetes v1.33, the
endpointsresource is deprecated.This PR updates Longhorn to replace endpoints with
endpointslices.Special notes for your reviewer:
For each ShareManager, there will now be two EndpointSlices:
kubernetes controllerServicelonghorn-managerShareManagerWe cannot directly modify the Kubernetes-managed EndpointSlice, since changes will be reverted during reconciliation.
Instead, longhorn-manager creates its own EndpointSlice to support use cases such as Multus.
As a result, a ShareManager Service may have two EndpointSlices. Consumers (e.g., kube-proxy, CNI) will aggregate them into a unified set of endpoints.
Additional documentation or context
https://kubernetes.io/docs/concepts/services-networking/endpoint-slices/