Skip to content

feat(controller): support endpointslices to replace endpoints #4161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidcheng0922 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(controller): support endpointslices to replace endpoints #4161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion controller/controller_manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,10 @@ func StartControllers(logger logrus.FieldLogger, clients *client.Clients,
if err != nil {
return nil, err
}
kubernetesEngpointSlicesController, err := NewKubernetesEndpointSlicesController(logger, ds, kubeClient, controllerID, namespace)
if err != nil {
return nil, err
}

// Start goroutines for Longhorn controllers
go replicaController.Run(Workers, stopCh)
Expand Down Expand Up @@ -220,7 +224,19 @@ func StartControllers(logger logrus.FieldLogger, clients *client.Clients,
go kubernetesConfigMapController.Run(Workers, stopCh)
go kubernetesSecretController.Run(Workers, stopCh)
go kubernetesPDBController.Run(Workers, stopCh)
go kubernetesEndpointController.Run(Workers, stopCh)

isAtLeast1_33, err := util.IsKubernetesVersionAtLeast(kubeClient, util.KubernetesVersion1_33)
if err != nil {
return nil, errors.Wrap(err, "failed to determine kubernetes version in controller manager")
}
if isAtLeast1_33 {
logger.Info("Kubernetes version is at least v1.33.0, using EndpointSlice controller")
go kubernetesEngpointSlicesController.Run(Workers, stopCh)
} else {
// Endpoint is deprecated in v1.33+
logger.Info("Kubernetes version is below v1.33.0, using Endpoint controller")
go kubernetesEndpointController.Run(Workers, stopCh)
}

return websocketController, nil
}
Expand Down
Loading
Loading