Skip to content

fix: show correct input/output in experiment results#13165

Merged
greglobinski merged 4 commits intomainfrom
fix-dataset-item-run-result
Feb 18, 2026
Merged

fix: show correct input/output in experiment results#13165
greglobinski merged 4 commits intomainfrom
fix-dataset-item-run-result

Conversation

@YujohnNattrass
Copy link
Collaborator

@YujohnNattrass YujohnNattrass commented Feb 17, 2026

The experiment result detail panel was showing result.output under the "Input" label, and the actual output wasn't shown at all. The results list table was also missing an Input column.

Before: detail panel shows output as input, no output section, list table has no input column.
After: detail panel correctly shows result.input as Input and result.output as Output, list table includes both Input and Output columns.

before: incorrect input shown

Screenshot 2026-02-17 at 3 44 28 PM

before: missing input field
Screenshot 2026-02-17 at 3 44 13 PM

after
Screenshot 2026-02-17 at 3 43 02 PM
Screenshot 2026-02-17 at 3 43 17 PM

Summary by CodeRabbit

  • Bug Fixes

    • Corrected mislabeling in the experiment result detail panel where output data was incorrectly displayed under the Input label
    • Added the missing Output section to properly separate and display experiment result outputs
  • New Features

    • Added an Input column to the experiment results list table for better visibility of input data alongside outputs

YJ and others added 2 commits February 17, 2026 15:45
- Fix detail panel displaying output data under 'Input' label
- Add missing Output section to detail panel
- Add Input column to experiment results list table

Co-Authored-By: Mastra Code <noreply@mastra.ai>
Co-Authored-By: Mastra Code <noreply@mastra.ai>
@vercel
Copy link

vercel bot commented Feb 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
mastra-docs Ready Ready Preview, Comment Feb 18, 2026 8:58am
mastra-docs-1.x Building Building Preview, Comment Feb 18, 2026 8:58am

Request Review

@changeset-bot
Copy link

changeset-bot bot commented Feb 17, 2026

🦋 Changeset detected

Latest commit: 9faa949

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@mastra/playground-ui Patch
@internal/playground Patch
mastra Patch
create-mastra Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 17, 2026

Walkthrough

This PR fixes incorrect input/output labeling in the experiment results UI. The Input section was previously displaying output data; this change properly distinguishes input and output in the detail panel and adds an Input column to the results table, visible when no featured result is selected.

Changes

Cohort / File(s) Summary
Changeset Documentation
.changeset/fix-experiment-result-input-output.md
Documents patch fixing input/output mislabeling in experiment result panel and introducing Input column to results list table.
Experiment Result Panel
packages/playground-ui/src/domains/experiments/components/experiment-result-panel.tsx
Corrects Input section to display formatted input data (inputStr) instead of output; adds dedicated Output section with formatted output data (outputStr).
Experiment Results List Configuration
packages/playground-ui/src/domains/experiments/components/experiment-results-list-and-details.tsx, experiment-results-list.tsx
Conditionally adds Input and Output columns to results table when no featured result is selected; implements column rendering for truncated input values matching output column formatting.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main fix: correcting the display of input/output in experiment results. It follows imperative mood with the 'fix:' prefix, is under 50 characters (52), and directly relates to the changeset's core purpose of fixing mislabeling issues.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-dataset-item-run-result

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
packages/playground-ui/src/domains/experiments/components/experiment-results-list-and-details.tsx (1)

86-87: Consider consolidating the two !featuredResultId spreads

Both lines evaluate the same condition. They can be merged into a single spread for clarity.

♻️ Proposed refactor
-    ...(!featuredResultId ? [{ name: 'input', label: 'Input', size: '1fr' }] : []),
-    ...(!featuredResultId ? [{ name: 'output', label: 'Output', size: '1fr' }] : []),
+    ...(!featuredResultId
+      ? [
+          { name: 'input', label: 'Input', size: '1fr' },
+          { name: 'output', label: 'Output', size: '1fr' },
+        ]
+      : []),
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In
`@packages/playground-ui/src/domains/experiments/components/experiment-results-list-and-details.tsx`
around lines 86 - 87, In experiment-results-list-and-details.tsx the two array
spreads that both check !featuredResultId (the lines spreading [{ name: 'input',
... }] and [{ name: 'output', ... }]) should be consolidated into a single
spread guarded by !featuredResultId; replace the two separate spreads with one
spread that inserts both objects (input and output) when featuredResultId is
falsy to improve clarity and avoid duplicated condition checks.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.changeset/fix-experiment-result-input-output.md:
- Line 5: Update the changeset description to use the past-tense allowed verb
"Fixed" instead of the imperative "Fix" in the summary text ("Fix experiment
result detail panel showing output data under \"Input\" label..."); edit the
changeset content so the first word is "Fixed" and keep the rest of the message
unchanged to comply with the allowed verbs guideline.

---

Nitpick comments:
In
`@packages/playground-ui/src/domains/experiments/components/experiment-results-list-and-details.tsx`:
- Around line 86-87: In experiment-results-list-and-details.tsx the two array
spreads that both check !featuredResultId (the lines spreading [{ name: 'input',
... }] and [{ name: 'output', ... }]) should be consolidated into a single
spread guarded by !featuredResultId; replace the two separate spreads with one
spread that inserts both objects (input and output) when featuredResultId is
falsy to improve clarity and avoid duplicated condition checks.

"@mastra/playground-ui": patch
---

Fix experiment result detail panel showing output data under "Input" label, add missing Output section, and add Input column to experiment results list table.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Use "Fixed" instead of "Fix" (guideline violation — potential_issue)

The changeset description must use a past-tense action verb from the allowed list (Added, Fixed, Improved, Deprecated, Removed). Fix is imperative and not in the list.

✏️ Proposed fix
-Fix experiment result detail panel showing output data under "Input" label, add missing Output section, and add Input column to experiment results list table.
+Fixed experiment result detail panel incorrectly displaying output data under the "Input" label. Now correctly shows input and output data in separate labelled sections, and added an Input column to the results list table.

As per coding guidelines: "Use action-oriented verbs (Added, Fixed, Improved, Deprecated, Removed)".

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.changeset/fix-experiment-result-input-output.md at line 5, Update the
changeset description to use the past-tense allowed verb "Fixed" instead of the
imperative "Fix" in the summary text ("Fix experiment result detail panel
showing output data under \"Input\" label..."); edit the changeset content so
the first word is "Fixed" and keep the rest of the message unchanged to comply
with the allowed verbs guideline.

@greglobinski greglobinski merged commit 824c1ab into main Feb 18, 2026
36 of 37 checks passed
@greglobinski greglobinski deleted the fix-dataset-item-run-result branch February 18, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments