Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-experiment-result-input-output.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@mastra/playground-ui": patch
---

Fix experiment result detail panel showing output data under "Input" label, add missing Output section, and add Input column to experiment results list table.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Use "Fixed" instead of "Fix" (guideline violation — potential_issue)

The changeset description must use a past-tense action verb from the allowed list (Added, Fixed, Improved, Deprecated, Removed). Fix is imperative and not in the list.

✏️ Proposed fix
-Fix experiment result detail panel showing output data under "Input" label, add missing Output section, and add Input column to experiment results list table.
+Fixed experiment result detail panel incorrectly displaying output data under the "Input" label. Now correctly shows input and output data in separate labelled sections, and added an Input column to the results list table.

As per coding guidelines: "Use action-oriented verbs (Added, Fixed, Improved, Deprecated, Removed)".

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.changeset/fix-experiment-result-input-output.md at line 5, Update the
changeset description to use the past-tense allowed verb "Fixed" instead of the
imperative "Fix" in the summary text ("Fix experiment result detail panel
showing output data under \"Input\" label..."); edit the changeset content so
the first word is "Fixed" and keep the rest of the message unchanged to comply
with the allowed verbs guideline.

Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ export function ExperimentResultPanel({
onShowTrace,
}: ExperimentResultPanelProps) {
const hasError = Boolean(result.error);
const inputStr = formatValue(result.input);
const outputStr = formatValue(result.output);

return (
Expand Down Expand Up @@ -61,7 +62,8 @@ export function ExperimentResultPanel({
</MainHeader.Column>
</MainHeader>

<SideDialog.CodeSection title="Input" icon={<FileOutputIcon />} codeStr={outputStr} />
<SideDialog.CodeSection title="Input" icon={<FileCodeIcon />} codeStr={inputStr} />
<SideDialog.CodeSection title="Output" icon={<FileOutputIcon />} codeStr={outputStr} />

<div className="grid gap-2">
<h4 className="text-sm font-medium text-neutral5 flex items-center gap-2">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ export function ExperimentResultsListAndDetails({ results, isLoading }: Experime

const resultsListColumns = [
{ name: 'itemId', label: 'Item ID', size: '5rem' },
...(!featuredResultId ? [{ name: 'input', label: 'Input', size: '1fr' }] : []),
...(!featuredResultId ? [{ name: 'output', label: 'Output', size: '1fr' }] : []),
{ name: 'status', label: 'Status', size: '3rem' },
];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,9 @@ export function ExperimentResultsList({
onClick={() => onResultClick(result.id)}
>
<ItemList.TextCell>{result.itemId.slice(0, 8)}</ItemList.TextCell>
{columns.some(col => col.name === 'input') && (
<ItemList.TextCell>{truncate(formatValue(result.input), 200)}</ItemList.TextCell>
)}
{columns.some(col => col.name === 'output') && (
<ItemList.TextCell>{truncate(formatValue(result.output), 200)}</ItemList.TextCell>
)}
Expand Down