update version checker to load the JSON response#230
Open
pUrGe12 wants to merge 1 commit intomegadose:masterfrom
Open
update version checker to load the JSON response#230pUrGe12 wants to merge 1 commit intomegadose:masterfrom
pUrGe12 wants to merge 1 commit intomegadose:masterfrom
Conversation
…annot be directly loaded as json
ChadAPSheridan
pushed a commit
to ChadAPSheridan/holehe
that referenced
this pull request
Oct 19, 2025
- [Fix Dockerfile megadose#210](megadose#210) - [Fix broken setup.py (missing dependencies) megadose#222](megadose#222) - [update version checker to load the JSON response megadose#230](megadose#230) Update Dockerfile and README for improved installation instructions - Upgrade Python base image to 3.13.9-slim-trixie (to address crit vulnerabilities in previous image) - Simplify Dockerfile installation commands - Add Docker usage instructions to README with a note on docker-buildx requirement (for futureproofing)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current way of pulling the latest release and checking for updates is broken because httpx is returning a response type field which cannot be loaded using .json(). Instead we can get the text output (which will be a jsonified string) and load that with json.loads()