Skip to content
/ holehe Public

update version checker to load the JSON response #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pUrGe12 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

update version checker to load the JSON response #230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions holehe/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@ def get_functions(modules,args=None):

def check_update():
"""Check and update holehe if not the last version"""
check_version = httpx.get("https://pypi.org/pypi/holehe/json")
if check_version.json()["info"]["version"] != __version__:
check_version = httpx.get("https://pypi.org/pypi/holehe/json").text
if json.loads(check_version)["info"]["version"] != __version__:
if os.name != 'nt':
p = Popen(["pip3",
"install",
Expand Down