Skip to content

[Quality Management] Various changes 2 #6453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JakovljevicDusan merged 6 commits into from
Feb 4, 2026
Merged

[Quality Management] Various changes 2 #6453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
189e871
"Quality Inspection Nos." in the Setup page, tooltip mentions Nos. in…
JakovljevicDusan Feb 3, 2026
60f7f9d
Implement ClearLastError()
JakovljevicDusan Feb 3, 2026
dd93dee
Improve Page Extensions
JakovljevicDusan Feb 3, 2026
9ad50c6
Performance: QltyManufacturIntegration - Nested Loops with Multiple R…
JakovljevicDusan Feb 4, 2026
bb0d680
Merge branch 'main' of https://github.com/microsoft/BCApps into bugs/…
JakovljevicDusan Feb 4, 2026
c2572f1
Fix ClearLastError
JakovljevicDusan Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Apps/W1/Quality Management/app/src/Integration/Assembly/QltyAsmGenRuleWizard.Page.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ page 20464 "Qlty. Asm. Gen. Rule Wizard"

trigger OnValidate()
begin
ClearLastError();
if not UpdateFullTextRuleStringsFromFilters() then
Error(LocationFilterErr, GetLastErrorText());
end;
Expand All @@ -92,6 +93,7 @@ page 20464 "Qlty. Asm. Gen. Rule Wizard"

trigger OnValidate()
begin
ClearLastError();
if not UpdateFullTextRuleStringsFromFilters() then
Error(ToBinFilterErr, GetLastErrorText());
end;
Expand Down Expand Up @@ -140,6 +142,7 @@ page 20464 "Qlty. Asm. Gen. Rule Wizard"

trigger OnValidate()
begin
ClearLastError();
if not UpdateFullTextRuleStringsFromFilters() then
Error(ItemFilterErr, GetLastErrorText());
end;
Expand All @@ -157,6 +160,7 @@ page 20464 "Qlty. Asm. Gen. Rule Wizard"

trigger OnValidate()
begin
ClearLastError();
if not UpdateFullTextRuleStringsFromFilters() then
Error(ItemCategoryFilterErr, GetLastErrorText());
end;
Expand All @@ -174,6 +178,7 @@ page 20464 "Qlty. Asm. Gen. Rule Wizard"

trigger OnValidate()
begin
ClearLastError();
if not UpdateFullTextRuleStringsFromFilters() then
Error(InventoryPostingGroupErr, GetLastErrorText());
end;
Expand Down
28 changes: 7 additions & 21 deletions src/Apps/W1/Quality Management/app/src/Integration/Inventory/Item/QltyItemCard.PageExt.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,43 +12,29 @@ pageextension 20430 "Qlty. Item Card" extends "Item Card"
{
actions
{
addlast(Navigation_Item)
addlast(navigation)
{
action(Qlty_QualityInspections)
{
ApplicationArea = QualityManagement;
Caption = 'Quality Inspections';
Image = TaskQualityMeasure;
ToolTip = 'View quality inspections filtered by the selected item.';
Visible = QltyReadTestResults;

trigger OnAction()
begin
ShowQualityInspections();
end;
Visible = QltyReadQualityInspections;
RunObject = Page "Qlty. Inspection List";
RunPageLink = "Source Item No." = field("No.");
RunPageView = sorting("Source Item No.");
}
}
}

var
QltyReadTestResults: Boolean;
QltyReadQualityInspections: Boolean;

trigger OnOpenPage()
var
CheckLicensePermissionQltyInspectionHeader: Record "Qlty. Inspection Header";
QltyPermissionMgmt: Codeunit "Qlty. Permission Mgmt.";
begin
if not CheckLicensePermissionQltyInspectionHeader.ReadPermission() then
exit;

QltyReadTestResults := QltyPermissionMgmt.CanReadInspectionResults();
end;

local procedure ShowQualityInspections()
var
QltyInspectionHeader: Record "Qlty. Inspection Header";
begin
QltyInspectionHeader.SetRange("Source Item No.", Rec."No.");
Page.Run(Page::"Qlty. Inspection List", QltyInspectionHeader);
QltyReadQualityInspections := QltyPermissionMgmt.CanReadInspectionResults();
end;
}
28 changes: 7 additions & 21 deletions src/Apps/W1/Quality Management/app/src/Integration/Inventory/Item/QltyItemList.PageExt.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,43 +12,29 @@ pageextension 20431 "Qlty. Item List" extends "Item List"
{
actions
{
addlast(Action126)
addlast(navigation)
{
action(Qlty_QualityInspections)
{
ApplicationArea = QualityManagement;
Caption = 'Quality Inspections';
Image = TaskQualityMeasure;
ToolTip = 'View quality inspections filtered by the selected item.';
Visible = QltyReadTestResults;

trigger OnAction()
begin
ShowQualityInspections();
end;
Visible = QltyReadQualityInspections;
RunObject = Page "Qlty. Inspection List";
RunPageLink = "Source Item No." = field("No.");
RunPageView = sorting("Source Item No.");
}
}
}

var
QltyReadTestResults: Boolean;
QltyReadQualityInspections: Boolean;

trigger OnOpenPage()
var
CheckLicensePermissionQltyInspectionHeader: Record "Qlty. Inspection Header";
QltyPermissionMgmt: Codeunit "Qlty. Permission Mgmt.";
begin
if not CheckLicensePermissionQltyInspectionHeader.ReadPermission() then
exit;

QltyReadTestResults := QltyPermissionMgmt.CanReadInspectionResults();
end;

local procedure ShowQualityInspections()
var
QltyInspectionHeader: Record "Qlty. Inspection Header";
begin
QltyInspectionHeader.SetRange("Source Item No.", Rec."No.");
Page.Run(Page::"Qlty. Inspection List", QltyInspectionHeader);
QltyReadQualityInspections := QltyPermissionMgmt.CanReadInspectionResults();
end;
}
29 changes: 7 additions & 22 deletions ...s/W1/Quality Management/app/src/Integration/Inventory/Item/QltyItemVariantCard.PageExt.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,37 +20,22 @@ pageextension 20433 "Qlty. Item Variant Card" extends "Item Variant Card"
Caption = 'Quality Inspections';
Image = TaskQualityMeasure;
ToolTip = 'View quality inspections filtered by the selected item and variant.';
Visible = QltyReadTestResults;

trigger OnAction()
begin
ShowQualityInspections();
end;
Visible = QltyReadQualityInspections;
RunObject = Page "Qlty. Inspection List";
RunPageLink = "Source Item No." = field("Item No."),
"Source Variant Code" = field("Code");
RunPageView = sorting("Source Item No.", "Source Variant Code");
}
}
}

var
QltyReadTestResults: Boolean;
QltyReadQualityInspections: Boolean;

trigger OnOpenPage()
var
CheckLicensePermissionQltyInspectionHeader: Record "Qlty. Inspection Header";
QltyPermissionMgmt: Codeunit "Qlty. Permission Mgmt.";
begin
if not CheckLicensePermissionQltyInspectionHeader.ReadPermission() then
exit;

QltyReadTestResults := QltyPermissionMgmt.CanReadInspectionResults();
end;

local procedure ShowQualityInspections()
var
QltyInspectionHeader: Record "Qlty. Inspection Header";
begin
QltyInspectionHeader.SetRange("Source Item No.", Rec."Item No.");
if Rec.Code <> '' then
QltyInspectionHeader.SetRange("Source Variant Code", Rec.Code);
Page.Run(Page::"Qlty. Inspection List", QltyInspectionHeader);
QltyReadQualityInspections := QltyPermissionMgmt.CanReadInspectionResults();
end;
}
29 changes: 7 additions & 22 deletions ...Apps/W1/Quality Management/app/src/Integration/Inventory/Item/QltyItemVariants.PageExt.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,37 +20,22 @@ pageextension 20432 "Qlty. Item Variants" extends "Item Variants"
Caption = 'Quality Inspections';
Image = TaskQualityMeasure;
ToolTip = 'View quality inspections filtered by the selected item and variant.';
Visible = QltyReadTestResults;

trigger OnAction()
begin
ShowQualityInspections();
end;
Visible = QltyReadQualityInspections;
RunObject = Page "Qlty. Inspection List";
RunPageLink = "Source Item No." = field("Item No."),
"Source Variant Code" = field("Code");
RunPageView = sorting("Source Item No.", "Source Variant Code");
}
}
}

var
QltyReadTestResults: Boolean;
QltyReadQualityInspections: Boolean;

trigger OnOpenPage()
var
CheckLicensePermissionQltyInspectionHeader: Record "Qlty. Inspection Header";
QltyPermissionMgmt: Codeunit "Qlty. Permission Mgmt.";
begin
if not CheckLicensePermissionQltyInspectionHeader.ReadPermission() then
exit;

QltyReadTestResults := QltyPermissionMgmt.CanReadInspectionResults();
end;

local procedure ShowQualityInspections()
var
QltyInspectionHeader: Record "Qlty. Inspection Header";
begin
QltyInspectionHeader.SetRange("Source Item No.", Rec."Item No.");
if Rec.Code <> '' then
QltyInspectionHeader.SetRange("Source Variant Code", Rec.Code);
Page.Run(Page::"Qlty. Inspection List", QltyInspectionHeader);
QltyReadQualityInspections := QltyPermissionMgmt.CanReadInspectionResults();
end;
}
2 changes: 2 additions & 0 deletions ...W1/Quality Management/app/src/Integration/Inventory/QltyItemJournalManagement.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,7 @@ codeunit 20454 "Qlty. Item Journal Management"
ToPostWarehouseJournalLine.SetRecFilter();
if not ConsideredLines.Contains(Format(ToPostWarehouseJournalLine.RecordId())) then begin
Commit();
ClearLastError();
if not WhseJnlRegisterBatch.Run(ToPostWarehouseJournalLine) then begin
ErrorMessage := GetLastErrorText();
ErrorStack := GetLastErrorCallStack();
Expand Down Expand Up @@ -354,6 +355,7 @@ codeunit 20454 "Qlty. Item Journal Management"

if not ConsideredLines.Contains(Format(ToPostItemJournalLine.RecordId())) then begin
Commit();
ClearLastError();
if not ItemJnlPostBatch.Run(ToPostItemJournalLine) then begin
ErrorMessage := GetLastErrorText();
ErrorStack := GetLastErrorCallStack();
Expand Down
14 changes: 5 additions & 9 deletions ...s/W1/Quality Management/app/src/Integration/Inventory/Tracking/QltyItemTracing.PageExt.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@ pageextension 20428 "Qlty. Item Tracing" extends "Item Tracing"
Caption = 'Quality Inspections';
Image = TaskQualityMeasure;
ToolTip = 'View quality inspections filtered by the selected item, variant, location, and tracking details.';
Visible = QltyReadTestResults;
Visible = QltyReadQualityInspections;

trigger OnAction()
trigger OnAction()
begin
ShowQualityInspections();
end;
Expand All @@ -31,17 +31,13 @@ pageextension 20428 "Qlty. Item Tracing" extends "Item Tracing"
}

var
QltyReadTestResults: Boolean;
QltyReadQualityInspections: Boolean;

trigger OnOpenPage()
var
CheckLicensePermissionQltyInspectionHeader: Record "Qlty. Inspection Header";
QltyPermissionMgmt: Codeunit "Qlty. Permission Mgmt.";
begin
if not CheckLicensePermissionQltyInspectionHeader.ReadPermission() then
exit;

QltyReadTestResults := QltyPermissionMgmt.CanReadInspectionResults();
QltyReadQualityInspections := QltyPermissionMgmt.CanReadInspectionResults();
end;

local procedure ShowQualityInspections()
Expand All @@ -50,7 +46,7 @@ pageextension 20428 "Qlty. Item Tracing" extends "Item Tracing"
begin
QltyInspectionHeader.SetFilter("Source Item No.", ItemNoFilter);
if VariantFilter <> '' then
QltyInspectionHeader.SetFilter("Source Variant Code", VariantFilter);
QltyInspectionHeader.SetFilter("Source Variant Code", VariantFilter);
if SerialNoFilter <> '' then
QltyInspectionHeader.SetFilter("Source Serial No.", SerialNoFilter);
if LotNoFilter <> '' then
Expand Down
10 changes: 3 additions & 7 deletions ...lity Management/app/src/Integration/Inventory/Tracking/QltyItemTrackingEntries.PageExt.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ pageextension 20429 "Qlty. Item Tracking Entries" extends "Item Tracking Entries
Caption = 'Quality Inspections';
Image = TaskQualityMeasure;
ToolTip = 'View quality inspections filtered by the selected item, variant, location, and tracking details.';
Visible = QltyReadTestResults;
Visible = QltyReadQualityInspections;

trigger OnAction()
begin
Expand All @@ -31,17 +31,13 @@ pageextension 20429 "Qlty. Item Tracking Entries" extends "Item Tracking Entries
}

var
QltyReadTestResults: Boolean;
QltyReadQualityInspections: Boolean;

trigger OnOpenPage()
var
CheckLicensePermissionQltyInspectionHeader: Record "Qlty. Inspection Header";
QltyPermissionMgmt: Codeunit "Qlty. Permission Mgmt.";
begin
if not CheckLicensePermissionQltyInspectionHeader.ReadPermission() then
exit;

QltyReadTestResults := QltyPermissionMgmt.CanReadInspectionResults();
QltyReadQualityInspections := QltyPermissionMgmt.CanReadInspectionResults();
end;

local procedure ShowQualityInspections()
Expand Down
24 changes: 12 additions & 12 deletions ...uality Management/app/src/Integration/Inventory/Tracking/QltyItemTrackingLines.PageExt.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,22 +12,22 @@ pageextension 20418 "Qlty. Item Tracking Lines" extends "Item Tracking Lines"
{
actions
{
addafter(ButtonLineReclass)
addlast(navigation)
{
group(Qlty_Management)
group(Qlty_QualityManagement)
{
Caption = 'Quality Management';

action(Qlty_InspectionCreate)
action(Qlty_CreateQualityInspections)
{
ApplicationArea = QualityManagement;
Image = CreateForm;
Caption = 'Create Quality Inspections';
ToolTip = 'Creates multiple quality inspections for the selected item tracking lines.';
AboutTitle = 'Create Quality Inspections for selected lines';
AboutText = 'Select multiple records, and then use this action to create multiple quality inspections for the selected item tracking lines.';
Enabled = QltyShowCreateInspection;
Visible = QltyShowCreateInspection;
Enabled = QltyCreateQualityInspections;
Visible = QltyCreateQualityInspections;

trigger OnAction()
var
Expand All @@ -38,16 +38,16 @@ pageextension 20418 "Qlty. Item Tracking Lines" extends "Item Tracking Lines"
Rec.Reset();
end;
}
action(Qlty_InspectionShowInspectionsForItem)
action(Qlty_ShowQualityInspectionsForItem)
{
ApplicationArea = QualityManagement;
Image = TaskQualityMeasure;
Caption = 'Show Quality Inspections for Item with tracking specification';
ToolTip = 'Shows Quality Inspections for Item with tracking specification';
AboutTitle = 'Show Quality Inspections';
AboutText = 'Shows quality inspections for this item with tracking specification.';
Enabled = QltyReadTestResults;
Visible = QltyReadTestResults;
Enabled = QltyReadQualityInspections;
Visible = QltyReadQualityInspections;

trigger OnAction()
var
Expand All @@ -61,18 +61,18 @@ pageextension 20418 "Qlty. Item Tracking Lines" extends "Item Tracking Lines"
}

var
QltyReadTestResults: Boolean;
QltyShowCreateInspection: Boolean;
QltyReadQualityInspections, QltyCreateQualityInspections : Boolean;

trigger OnOpenPage()
var
CheckLicensePermissionQltyInspectionHeader: Record "Qlty. Inspection Header";
QltyPermissionMgmt: Codeunit "Qlty. Permission Mgmt.";
begin
QltyReadQualityInspections := QltyPermissionMgmt.CanReadInspectionResults();

if not CheckLicensePermissionQltyInspectionHeader.WritePermission() then
exit;

QltyShowCreateInspection := QltyPermissionMgmt.CanCreateManualInspection();
QltyReadTestResults := QltyPermissionMgmt.CanReadInspectionResults();
QltyCreateQualityInspections := QltyPermissionMgmt.CanCreateManualInspection();
end;
}
2 changes: 1 addition & 1 deletion ...lity Management/app/src/Integration/Inventory/Tracking/QltyItemTrackingSummary.PageExt.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ pageextension 20409 "Qlty. Item Tracking Summary" extends "Item Tracking Summary
{
layout
{
addafter("Total Available Quantity")
addafter("Selected Quantity")
{
field(QltyInspectionResultDescription; MostRecentQltyResultDescription)
{
Expand Down
Loading
Loading