bug(nimbus): set default values on backend, not frontend#13116
Merged
jaredlockhart merged 3 commits intomainfrom Jul 29, 2025
Merged
bug(nimbus): set default values on backend, not frontend#13116jaredlockhart merged 3 commits intomainfrom
jaredlockhart merged 3 commits intomainfrom
Conversation
jaredlockhart
requested review from
freshstrangemusic and
yashikakhurana
as code owners
yashikakhurana
approved these changes
Jul 28, 2025
Contributor
yashikakhurana
left a comment
yashikakhurana
left a comment
There was a problem hiding this comment.
perfect, quick fix, thank you @jaredlockhart
Because
* We recently added a case that prepopulate the feature value with "{}" when features are selected
* This caused the frontend to display "{}" as the feature value, and yet in the backend it is None
* This causes the review serializer to indicate that a field is not filled in when it looks as if it is
This commit
* Removes the default "{}" value from the frontend
* Sets it in the backend
* This way the state displayed and state validated are the same
fixes #13113
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This commit
fixes #13113