Skip to content

bug(nimbus): set default values on backend, not frontend #13116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaredlockhart merged 3 commits into from
Jul 29, 2025
Merged

bug(nimbus): set default values on backend, not frontend #13116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7a1a2f7
bug(nimbus): set default values on backend, not frontend
jaredlockhart Jul 28, 2025
5861756
Merge branch 'main' into 13113
freshstrangemusic Jul 28, 2025
af7d59a
Merge branch 'main' into 13113
freshstrangemusic Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion experimenter/experimenter/nimbus_ui/forms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -716,7 +716,7 @@ def save(self, *args, **kwargs):
).delete()

for feature_config in new_feature_configs:
branch.feature_values.create(feature_config=feature_config)
branch.feature_values.create(feature_config=feature_config, value="{}")

if experiment.equal_branch_ratio:
experiment.branches.all().update(ratio=1)
Expand Down
2 changes: 1 addition & 1 deletion experimenter/experimenter/nimbus_ui/static/js/edit_branches.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const setupCodemirror = (selector, textarea, extraExtensions) => {
];

const view = new EditorView({
doc: textarea.value || "{}",
doc: textarea.value,
extensions,
parent: textarea.parentNode,
});
Expand Down
4 changes: 2 additions & 2 deletions experimenter/experimenter/nimbus_ui/tests/test_forms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1910,7 +1910,7 @@ def test_branches_form_saves_added_feature_config(self):
)
self.assertTrue(
experiment.reference_branch.feature_values.filter(
feature_config=feature_config2
feature_config=feature_config2, value="{}"
).exists()
)

Expand All @@ -1921,7 +1921,7 @@ def test_branches_form_saves_added_feature_config(self):
)
self.assertTrue(
treatment_branch.feature_values.filter(
feature_config=feature_config2
feature_config=feature_config2, value="{}"
).exists(),
)

Expand Down