chore(nimbus): Update application-services#13948
Merged
jaredlockhart merged 1 commit intomainfrom Nov 17, 2025
Merged
Conversation
experimenter-github-app
bot
force-pushed
the
update-application-services
branch
6 times, most recently
from
b0a735e to
6b7b1a2
Compare
jaredlockhart
approved these changes
Nov 13, 2025
freshstrangemusic
removed this pull request from the merge queue due to a manual request
freshstrangemusic
previously requested changes
Nov 13, 2025
| @pytest.fixture(name="sdk_client") | ||
| def fixture_sdk_client(): | ||
| def _client_helper(app_context): | ||
| return nimbus_rust.NimbusClient( |
Member
There was a problem hiding this comment.
This patch is wrong. You're adding a new arg at the end, but the args in the middle changed.
This should be:
return nimbus_rust.NimbusClient(
app_context,
None,
[],
str(Path.cwd()),
MockMetricsHandler(),
None,
None,
""
)
Member
There was a problem hiding this comment.
I tried to do a suggestion but if you include unchanged lines in the suggestion github breaks
experimenter-github-app
bot
force-pushed
the
update-application-services
branch
from
6cacdf7 to
2f9c728
Compare
experimenter-github-app
bot
force-pushed
the
update-application-services
branch
from
8c824d8 to
663ff14
Compare
Collaborator
|
Blocked on #13962 |
experimenter-github-app
bot
force-pushed
the
update-application-services
branch
7 times, most recently
from
84cd605 to
7ad393e
Compare
experimenter-github-app
bot
force-pushed
the
update-application-services
branch
from
7ad393e to
16b603e
Compare
jaredlockhart
approved these changes
Nov 17, 2025
jaredlockhart
dismissed
freshstrangemusic’s stale review
Client changes were handled in #13962
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.