feat(nimbus): Add advanced targeting for newtab trainhop 147.0.20251114.194929 for desktop#14118
Merged
yashikakhurana merged 2 commits intomozilla:mainfrom Dec 5, 2025
Merged
Conversation
…14.194929 for desktop - Reason This commit will allow us to create experiments targeting users of the latest New Tab trainhop that was released (2025-11-24) to Firefox 145 users on the release channel. - Change Fixes mozilla#14117
maxxcrawford
requested review from
freshstrangemusic,
jaredlockhart and
yashikakhurana
as code owners
….20251114.194929 for desktop
maxxcrawford
commented
Dec 4, 2025
|
|
||
| FX_146_1_TRAINHOP = NimbusTargetingConfig( | ||
| name="New Tab Fx146 11-24 Trainhop", | ||
| slug="newtab-146-1-1124-trainhop", |
Contributor
Author
There was a problem hiding this comment.
Note: Fixed issue where I had the same slug as the previous constant.
| application_choice_names=(Application.DESKTOP.name,), | ||
| ) | ||
|
|
||
| FX_146_1_TRAINHOP = NimbusTargetingConfig( |
Contributor
Author
There was a problem hiding this comment.
Note: Naming this is difficult. Very open to suggestions!
New Tab is targeting Fx145.0.1 users who have the 147.X train-hop.
yashikakhurana
approved these changes
Dec 4, 2025
Contributor
yashikakhurana
left a comment
yashikakhurana
left a comment
There was a problem hiding this comment.
Thanks @maxxcrawford
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit will allow us to create experiments targeting users of the latest New Tab trainhop that was released (2025-11-24) to Firefox 145 users on the release channel.
Fixes #14117