Skip to content

feat(nimbus): Add advanced targeting for newtab trainhop 147.0.20251114.194929 for desktop #14118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yashikakhurana merged 2 commits into from
Dec 5, 2025
Merged

feat(nimbus): Add advanced targeting for newtab trainhop 147.0.20251114.194929 for desktop #14118

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6c2d44
feat(nimbus): Add advanced targeting for newtab trainhop 147.0.202511…
maxxcrawford Dec 4, 2025
6363bd5
fixup! feat(nimbus): Add advanced targeting for newtab trainhop 147.0…
maxxcrawford Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions experimenter/experimenter/targeting/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3726,6 +3726,20 @@ def __post_init__(self):
application_choice_names=(Application.DESKTOP.name,),
)

FX_146_1_TRAINHOP = NimbusTargetingConfig(
Copy link
Contributor Author

@maxxcrawford maxxcrawford Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Naming this is difficult. Very open to suggestions!

New Tab is targeting Fx145.0.1 users who have the 147.X train-hop.

name="New Tab Fx146 11-24 Trainhop",
slug="newtab-146-1-1124-trainhop",
Copy link
Contributor Author

@maxxcrawford maxxcrawford Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Fixed issue where I had the same slug as the previous constant.

description=(
"Desktop users having the New Tab 147.0.20251114.194929 train hop, "
"which includes users of Fx145_0_1"
),
targeting="newtabAddonVersion|versionCompare('147.0.20251114.194929') >= 0",
desktop_telemetry="",
sticky_required=False,
is_first_run_required=False,
application_choice_names=(Application.DESKTOP.name,),
)

BUILDID_20251006095753 = NimbusTargetingConfig(
name="Build ID 20251006095753 or higher",
slug="buildid-20251006095753",
Expand Down