chore(nimbus): fix get_metric_areas intermittent coverage failure#14180
Merged
jaredlockhart merged 1 commit intomainfrom Dec 11, 2025
Merged
chore(nimbus): fix get_metric_areas intermittent coverage failure#14180jaredlockhart merged 1 commit intomainfrom
jaredlockhart merged 1 commit intomainfrom
Conversation
Because * We recently discovered an intermittent coverage failure in get_metric_areas * We fixed it by specifying an outcome in the test factory to trigger the uncovered lines * We forgot to also affix the application since that determines which outcomes to use This commit * Affixes both the application and outcome to trigger the uncovered lines fixes #14163
jaredlockhart
requested review from
freshstrangemusic and
yashikakhurana
as code owners
yashikakhurana
approved these changes
Dec 11, 2025
Contributor
yashikakhurana
left a comment
yashikakhurana
left a comment
There was a problem hiding this comment.
quick fix, thanks @jaredlockhart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This commit
fixes #14163