Conversation
📝 WalkthroughSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings. WalkthroughPre-commit hooks are restructured with prioritized grouping and new hook additions; dependency constraints are tightened for nanobind and mqt.core to exact versions; repo-review configuration updated with PC170 ignore entry. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.pre-commit-config.yaml:
- Around line 154-164: The ty-check hook’s entry uses a fragile nested
subprocess Python one-liner; replace it with a simple shell-based invocation or
a dedicated wrapper script to improve readability and maintainability: create a
small executable script (or use language: system with a bash -c style entry)
that runs the two uv commands in sequence (sync with --no-install-project
--inexact, then run ty with --no-sync) and forwards the exit code, then point
the hook’s entry to that script and update the language field accordingly (refer
to the hook id "ty-check", the "entry" and "language: unsupported" fields) while
leaving types_or, exclude and priority intact.
Description
This PR updates
.pre-commit-config.ymlto make use ofprek's priority feature. The commits were initially part of #921, which is blocked due to a CD issue.Checklist:
I have added appropriate tests that cover the new/changed functionality.I have updated the documentation to reflect these changes.I have added entries to the changelog for any noteworthy additions, changes, fixes, or removals.I have added migration instructions to the upgrade guide (if needed).