feat: use 🛻 pickup from api #2310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pickup pulls dags into E-IPFS, so this PR updates the api and cron jobs to reflect that in our db. - Update the pinning service add and update api routes to record `ElasticIpfs` as the service that the pin is queued on. - Update pins and pins-failed cron jobs to check pin status in pickup instead of cluster Fixes #2309 TODO - [ ] add `PICKUP_BASIC_AUTH_TOKEN` as a secret to the repo for cron jobs. - [ ] update `CLUSTER-*` api env vars. License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
Deploying with
|
| Latest commit: |
efa19ee
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cc296ca7.nft-storage-1at.pages.dev |
| Branch Preview URL: | https://use-pickup.nft-storage-1at.pages.dev |
Contributor
Author
|
This is blocked on pickup validator improvements web3-storage/pickup#97 |
olizilla
commented
Mar 7, 2023
Comment on lines
+54
to
+59
| pins: [ | ||
| { | ||
| status: 'PinQueued', | ||
| service: 'ElasticIpfs', // via pickup | ||
| }, | ||
| ], |
Contributor
Author
There was a problem hiding this comment.
We do this to override the default pin info that createUpload would set if we didn't provide this. New pins via pickup are provided via E-IPFS.
License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
2 tasks
olizilla
changed the title
cron changes now in #2339 License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
alanshaw
approved these changes
Mar 8, 2023
so we can set them in advance of deploy, and have the new code make use of them when it goes live. License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
Contributor
Author
|
Raised an issue for the dev worker deploy fail #2349 |
olizilla
pushed a commit
that referenced
this pull request
Mar 22, 2023
🤖 I have created a release *beep* *boop* --- ## [4.3.0](api-v4.2.1...api-v4.3.0) (2023-03-22) ### Features * use 🛻 pickup from api ([#2310](#2310)) ([e327bb3](e327bb3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pickup pulls dags into E-IPFS, so this PR updates the api to reflect that.
ElasticIpfsas the service that the pin is queued on.GET /pins/:req-idto check for a status change from pickup and update out DB, so we can inform users early when a pin request is pinned or failed.Cron changes are in #2339
Fixes #2309
TODO
PICKUP_BASIC_AUTH_TOKENas a secret to the repo for cron jobs.PICKUP_BASIC_AUTH_TOKENas worker secret for dev, staging, and prodLicense: MIT
Signed-off-by: Oli Evans oli@protocol.ai