feat: use 🛻 pickup from cron pins job #2339
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pickup pulls dags into E-IPFS, so this PR updates the api and cron jobs to reflect that in our db. - Update pins and pins-failed cron jobs to check pin status in pickup instead of cluster Fixes #2309 TODO - [x] add `PICKUP_BASIC_AUTH_TOKEN` as a secret to the repo for cron jobs. - [ ] update `CLUSTER-*` api env vars. License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
olizilla
changed the title
Deploying with
|
| Latest commit: |
f1826fd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://62dce27d.nft-storage-1at.pages.dev |
| Branch Preview URL: | https://cron-use-pickup.nft-storage-1at.pages.dev |
olizilla
added a commit
that referenced
this pull request
Mar 7, 2023
cron changes now in #2339 License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
olizilla
force-pushed
the
cron-use-pickup
branch
from
14056f0 to
183d837
Compare
olizilla
added a commit
that referenced
this pull request
Mar 7, 2023
cron changes now in #2339 License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
vasco-santos
approved these changes
Mar 7, 2023
Contributor
vasco-santos
left a comment
vasco-santos
left a comment
There was a problem hiding this comment.
LGTM. So #2310 will land first right?
olizilla
added a commit
that referenced
this pull request
Mar 22, 2023
pickup pulls dags into E-IPFS, so this PR updates the api to reflect that. - Update the pinning service add and update api routes to record `ElasticIpfs` as the service that the pin is queued on. - Update `GET /pins/:req-id` to check for a status change from pickup and update out DB, so we can inform users early when a pin request is pinned or failed. Cron changes are in #2339 Fixes #2309 License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
Contributor
|
@olizilla can it merge now? |
alanshaw
requested changes
May 10, 2023
alanshaw
approved these changes
May 10, 2023
Contributor
alanshaw
left a comment
alanshaw
left a comment
There was a problem hiding this comment.
LGTM apart from the URLs that need fixing.
olizilla
commented
May 10, 2023
Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Oli Evans <oli@protocol.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cron jobs to handle ElasticIPFS as cluster service.
Fixes #2309
Extracted from #2310 so we can deploy the api change first, but leave the old cron running for a few hours.
TODO
PICKUP_BASIC_AUTH_TOKENas a secret to the repo for cron jobs.CLUSTER-*api env vars.License: MIT