feat: implement using size prop for sheet component#4075
feat: implement using size prop for sheet component#4075filippovskii09 wants to merge 7 commits intoopenedx:release-23.xfrom
Conversation
|
Thanks for the pull request, @filippovskii09! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
✅ Deploy Preview for paragon-openedx-v23 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-23.x #4075 +/- ##
=============================================
Coverage 94.39% 94.39%
=============================================
Files 242 242
Lines 4296 4297 +1
Branches 1013 1021 +8
=============================================
+ Hits 4055 4056 +1
Misses 233 233
Partials 8 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
PKulkoRaccoonGang
left a comment
There was a problem hiding this comment.
Thanks for this PR, left a few comments
PKulkoRaccoonGang
left a comment
There was a problem hiding this comment.
This looks good! I’m not sure whether we want to support the size prop for the top and bottom positions. It would be great to hear others thoughts on this 💯
| width: 100%; | ||
|
|
||
| &.pgn__sheet-sm { | ||
| max-width: var(--pgn-size-sheet-sm); |
There was a problem hiding this comment.
Going along with @PKulkoRaccoonGang's comment #4075 (review) about if we want to
support the size prop for the
topandbottompositions
If this is specifically width, then we should call this width instead of size.
| max-width: 272px; | ||
| height: 100%; | ||
| top: 0; | ||
| width: 100%; |
There was a problem hiding this comment.
It's not clear to me why this is needed now when it wasn't before.
Description
Provide add a size prop with the values 'sm' | 'md' | 'lg' for the Sheet component
Issues
#3023
Preview
2026-01-08.11.00.38.mov