-
Notifications
You must be signed in to change notification settings - Fork 95
feat: implement using size prop for sheet component #4075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-23.x
Are you sure you want to change the base?
Changes from 5 commits
09d32aa
fd8a86d
03d8aac
642553e
730ddb3
d9d6768
76bfac4
357fe3a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -81,8 +81,20 @@ | |
|
|
||
| &.left, | ||
| &.right { | ||
| max-width: 272px; | ||
| height: 100%; | ||
| top: 0; | ||
| width: 100%; | ||
|
|
||
| &.pgn__sheet-sm { | ||
| max-width: var(--pgn-size-sheet-sm); | ||
|
||
| } | ||
|
|
||
| &.pgn__sheet-md { | ||
| max-width: var(--pgn-size-sheet-md); | ||
| } | ||
|
|
||
| &.pgn__sheet-lg { | ||
| max-width: var(--pgn-size-sheet-lg); | ||
| } | ||
PKulkoRaccoonGang marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not clear to me why this is needed now when it wasn't before.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added
width: 100%to keep the sheet responsive. With onlymax-width, it won’t shrink to the viewport, and without max-width (just width) it would always be full width even on large screens. Using both means it expands up to the max size but still fits smaller screens without overflowing.