Skip to content

Comments

Update license headers to 2025#18015

Merged
lsiepel merged 3 commits intoopenhab:mainfrom
wborn:update-license-headers
Jan 1, 2025
Merged

Update license headers to 2025#18015
lsiepel merged 3 commits intoopenhab:mainfrom
wborn:update-license-headers

Conversation

@wborn
Copy link
Member

@wborn wborn commented Jan 1, 2025

Updates the license headers to 2025.

@kaikreuzer
Copy link
Member

@wborn
Copy link
Member Author

wborn commented Jan 1, 2025

There are also issues with the ParameterizedRegexpHeaderCheck as it only works for headers starting with /**.

The license-maven-plugin nowadays uses /* for Java, Groovy headers as default as it is more common and prevents tooling issues, see mathieucarbou/license-maven-plugin#109.

I can create a PR for SAT to fix this. 🙂

@kaikreuzer
Copy link
Member

I can create a PR for SAT to fix this. 🙂

That would be nice.
I'd suggest to decouple the change of the year and the header syntax then into separate PRs.

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn force-pushed the update-license-headers branch from b5cf4b7 to 0ad6a2d Compare January 1, 2025 15:02
Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Wouter Born <github@maindrain.net>
Copy link
Member

@holgerfriedrich holgerfriedrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wborn wborn added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Jan 1, 2025
@lsiepel lsiepel added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Jan 1, 2025
@lsiepel lsiepel merged commit d647604 into openhab:main Jan 1, 2025
2 checks passed
@lsiepel lsiepel added this to the 5.0 milestone Jan 1, 2025
@wborn wborn deleted the update-license-headers branch January 1, 2025 23:44
@jlaur
Copy link
Contributor

jlaur commented Jan 2, 2025

@wborn - out of curiosity, how well did mvn license:format work this year? I had a few issues last time, see #16168.

@wborn
Copy link
Member Author

wborn commented Jan 2, 2025

Still some manual changes were needed, see the 9f5cc04 commit.

DrRSatzteil pushed a commit to DrRSatzteil/openhab-addons that referenced this pull request Jan 3, 2025
* Update license headers to 2025

Signed-off-by: Wouter Born <github@maindrain.net>
chilobo pushed a commit to chilobo/openhab-addons that referenced this pull request Feb 10, 2025
* Update license headers to 2025

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
phenix1990 pushed a commit to phenix1990/openhab-addons that referenced this pull request Jul 31, 2025
* Update license headers to 2025

Signed-off-by: Wouter Born <github@maindrain.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants