Merged
Conversation
* Fix failing validation in submodules (regression, openhab#18579) * Skip schema validation when -DskipChecks is set Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
andrewfg
approved these changes
Apr 20, 2025
Contributor
andrewfg
left a comment
andrewfg
left a comment
There was a problem hiding this comment.
LGTM thanks @holgerfriedrich :)
Contributor
|
@holgerfriedrich the |
Member
Author
|
@lsiepel FYI I will not fix the open point mentioned above in this PR. This can be merged once maintainers are fine with it. |
holgerfriedrich
added a commit
to holgerfriedrich/openhab-addons
that referenced
this pull request
Apr 23, 2025
* Move validation to subprojects, skip on top level to avoid double executuon (regression, openhab#18579) Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
holgerfriedrich
added a commit
to holgerfriedrich/openhab-addons
that referenced
this pull request
Apr 25, 2025
* Move validation to subprojects, skip on top level to avoid double executuon using a marker file (regression, openhab#18579) Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
holgerfriedrich
added a commit
to holgerfriedrich/openhab-addons
that referenced
this pull request
Apr 25, 2025
* Move validation to subprojects, skip on top level to avoid double execution using a marker file (regression, openhab#18579) Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
phenix1990
pushed a commit
to phenix1990/openhab-addons
that referenced
this pull request
Jul 31, 2025
* Fix failing validation in submodules (regression, openhab#18579) * Skip schema validation when -DskipChecks is set Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@andrewfg FYI
This fixes the broken build when run in a subdirectory for a specific add-on (second issue mentioned in #18579 (comment))
Though, it still validates all xml files when run on top level with
-plfor a specific add-on.