Maven Build: Validate Thing-type XML against schema

[andrewfg]

I went to great extents to modify the thing-description xml schema to be stricter in validating semantic tags against pre-defined allowed values. But then I discovered that the standard Maven build process does not actually do any xml schema validation at all. Maybe it was deleted at some time? Anyway this PR adds back the schema validation.

Signed-off-by: Andrew Fiddian-Green software@whitebear.ch

[andrewfg]

@jimtng .. for info.

[andrewfg]

Ping @holgerfriedrich ..

[lsiepel]

Thanks, LGTM

[jlaur]

@andrewfg - do you know why sometimes builds failed with validation errors and sometimes they passed (before this PR)?

[J-N-K]

LGTM

[andrewfg]

do you know why [sometimes builds failed with validation errors and sometimes they passed (before this PR)

Honestly no. Perhaps the tests were removed recently??

[holgerfriedrich]

Good to have the validation back in the build process.

Though, I have some issues with this PR:
When I try to run mvn install -pl :... to install a single plugin, it validates all xml files (this takes a while). See debug log from mvn -X ....
Second issue: When I run it from a plugin directory, it cannot properly locate `src/thing-type-xml-validation-catalog.xml

[andrewfg]

@holgerfriedrich there are 'directory' tags in the pom xml and the catalog xml files where we need to insert the right variable names to make it work. => Any thoughts?

// this should point to the directory where the build is started i.e. the `-pl` module location
<dir>${session.executionRootDirectory}</dir>

// this should always point to addons root directory
<catalog>${session.executionRootDirectory}/src/thing-type-xml-validation-catalog.xml</catalog>

[holgerfriedrich]

@holgerfriedrich there are 'directory' tags in the pom xml and the catalog xml files where we need to insert the right variable names to make it work. => Any thoughts?

// this should point to the directory where the build is started i.e. the `-pl` module location
<dir>${session.executionRootDirectory}</dir>

// this should always point to addons root directory
<catalog>${session.executionRootDirectory}/src/thing-type-xml-validation-catalog.xml</catalog>

It took me a while to find that we use directory-maven-plugin which sets basedirRoot - exactly what we need here. See #18581.

But I have not found a solution for the issue that it validates all xml files when mvn install -pl :... is run.

[openhab-bot]

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/californium-removed/163625/40