Skip to content

Comments

[heos] Fix bridge player channels#19457

Merged
lsiepel merged 1 commit intoopenhab:mainfrom
jlaur:heos-dynamic-channels
Oct 9, 2025
Merged

[heos] Fix bridge player channels#19457
lsiepel merged 1 commit intoopenhab:mainfrom
jlaur:heos-dynamic-channels

Conversation

@jlaur
Copy link
Contributor

@jlaur jlaur commented Oct 8, 2025

This fixes an issue with creating dynamic channels for a channel type that doesn't exist. It is not created dynamically using ChannelTypeBuilder and it's not defined statically in the XML either. This leads to warnings like this:

[WARN ] [core.thing.internal.ThingManagerImpl] - Failed to normalize configuration for new thing during update 'heos:bridge:denon': {thing/channel=Type description heos:chPlayer for heos:bridge:denon:Pdenon not found, although we checked the presence before.}

and the dynamic channels not being added to the bridge thing at all. It seems this goes all the way back to #6099.

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur requested a review from Wire82 as a code owner October 8, 2025 19:11
@jlaur jlaur added the bug An unexpected problem or unintended behavior of an add-on label Oct 8, 2025
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@lsiepel lsiepel merged commit 9a00341 into openhab:main Oct 9, 2025
3 checks passed
@lsiepel lsiepel added this to the 5.1 milestone Oct 9, 2025
lsiepel pushed a commit that referenced this pull request Oct 9, 2025
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
lsiepel pushed a commit that referenced this pull request Oct 9, 2025
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@lsiepel lsiepel added backported A PR that has been cherry-picked to a patch release branch backported4 Backported patches to the 4.x branch. Used for constructing release notes. labels Oct 9, 2025
@jlaur jlaur deleted the heos-dynamic-channels branch October 9, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backported A PR that has been cherry-picked to a patch release branch backported4 Backported patches to the 4.x branch. Used for constructing release notes. bug An unexpected problem or unintended behavior of an add-on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants