Skip to content

[heos] Fix bridge player channels #19457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lsiepel merged 1 commit into from
Oct 9, 2025
Merged

[heos] Fix bridge player channels #19457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ab.binding.heos/src/main/java/org/openhab/binding/heos/internal/HeosBindingConstants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public class HeosBindingConstants extends HeosConstants {
public static final ThingTypeUID THING_TYPE_PLAYER = new ThingTypeUID(BINDING_ID, "player");
public static final ThingTypeUID THING_TYPE_GROUP = new ThingTypeUID(BINDING_ID, "group");

// List off all Channel Types
// List of all Channel Types
public static final ChannelTypeUID CH_TYPE_PLAYER = new ChannelTypeUID(BINDING_ID, "chPlayer");

// List of all Channel IDs
Expand Down
5 changes: 3 additions & 2 deletions ...nding.heos/src/main/java/org/openhab/binding/heos/internal/handler/HeosBridgeHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
import org.openhab.binding.heos.internal.resources.HeosMediaEventListener;
import org.openhab.binding.heos.internal.resources.Telnet;
import org.openhab.binding.heos.internal.resources.Telnet.ReadException;
import org.openhab.core.library.CoreItemFactory;
import org.openhab.core.library.types.OnOffType;
import org.openhab.core.thing.Bridge;
import org.openhab.core.thing.Channel;
Expand Down Expand Up @@ -378,8 +379,8 @@ private void addPlayerChannel(Thing childThing, @Nullable String groupId) {
properties.put(PROP_NAME, playerName);
properties.put(PID, pid);

Channel channel = ChannelBuilder.create(channelUID, "Switch").withLabel(playerName).withType(CH_TYPE_PLAYER)
.withProperties(properties).build();
Channel channel = ChannelBuilder.create(channelUID, CoreItemFactory.SWITCH).withLabel(playerName)
.withType(CH_TYPE_PLAYER).withProperties(properties).build();
updateThingChannels(channelManager.addSingleChannel(channel));
} catch (HeosNotFoundException e) {
logger.debug("Group is not yet initialized fully");
Expand Down
1 change: 1 addition & 0 deletions bundles/org.openhab.binding.heos/src/main/resources/OH-INF/i18n/heos.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ thing-type.config.heos.player.pid.description = The internal Player ID

channel-type.heos.album.label = Album
channel-type.heos.buildGroup.label = Make Group
channel-type.heos.chPlayer.label = Player
channel-type.heos.clearQueue.label = Clear Queue
channel-type.heos.cover.label = Cover
channel-type.heos.currentPosition.label = Track Position
Expand Down
4 changes: 4 additions & 0 deletions bundles/org.openhab.binding.heos/src/main/resources/OH-INF/thing/Channels.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@
<tag>Mode</tag>
</tags>
</channel-type>
<channel-type id="chPlayer">
<item-type>Switch</item-type>
<label>Player</label>
</channel-type>
<channel-type id="playlists" advanced="true">
<item-type>String</item-type>
<label>Playlists</label>
Expand Down