Merged
Conversation
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Contributor
Author
|
@stefan-hoehn - maybe you have something to add here? |
Contributor
Author
|
This PR didn't break the images that already worked, but unfortunately it didn't fix those that don't work either. EDIT: Sorry, there hasn't been a build yet, so will have to check again: https://ci.openhab.org/view/Documentation/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix images in the Matter documentation.
There are four image files: https://github.com/openhab/openhab-addons/tree/main/bundles/org.openhab.binding.matter/doc
These images work:
<img src="./doc/bridge-settings.png" alt="Bridge Settings" width="500"/>becomes<img src="/assets/img/bridge-settings.e0306381.png" alt="Bridge Settings" width="500"><img src="./doc/bridge-settings-pair.png" alt="Commissioning Window" width="500"/>becomes<img src="/assets/img/bridge-settings-pair.d4048767.png" alt="Commissioning Window" width="500">And these do not:
<img src="doc/thing-discovery.png" alt="Thing Discovery" width="600"/>becomes<img src="doc/thing-discovery.png" alt="Thing Discovery" width="600"><img src="doc/pairing.png" alt="Matter Pairing" width="600"/>becomes<img src="doc/pairing.png" alt="Matter Pairing" width="600">The only difference seems to be the current directory reference in two of them:
./. Those two happens to be working, but I'm not sure that's the reason. Could it be that they all need to be either with or without? For example, the MyBMW binding doesn't use./and all images seem to work.It could also be a completely different issue that I have missed. In any case, it probably won't hurt to make these links consistent.