Skip to content

Comments

[matter] Fix image links#19470

Merged
lsiepel merged 1 commit intoopenhab:mainfrom
jlaur:matter-readme-images
Oct 16, 2025
Merged

[matter] Fix image links#19470
lsiepel merged 1 commit intoopenhab:mainfrom
jlaur:matter-readme-images

Conversation

@jlaur
Copy link
Contributor

@jlaur jlaur commented Oct 11, 2025

This is an attempt to fix images in the Matter documentation.

There are four image files: https://github.com/openhab/openhab-addons/tree/main/bundles/org.openhab.binding.matter/doc

These images work:

  • <img src="./doc/bridge-settings.png" alt="Bridge Settings" width="500"/> becomes <img src="/assets/img/bridge-settings.e0306381.png" alt="Bridge Settings" width="500">
  • <img src="./doc/bridge-settings-pair.png" alt="Commissioning Window" width="500"/> becomes <img src="/assets/img/bridge-settings-pair.d4048767.png" alt="Commissioning Window" width="500">

And these do not:

  • <img src="doc/thing-discovery.png" alt="Thing Discovery" width="600"/> becomes <img src="doc/thing-discovery.png" alt="Thing Discovery" width="600">
  • <img src="doc/pairing.png" alt="Matter Pairing" width="600"/> becomes <img src="doc/pairing.png" alt="Matter Pairing" width="600">

The only difference seems to be the current directory reference in two of them: ./. Those two happens to be working, but I'm not sure that's the reason. Could it be that they all need to be either with or without? For example, the MyBMW binding doesn't use ./ and all images seem to work.

It could also be a completely different issue that I have missed. In any case, it probably won't hurt to make these links consistent.

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur
Copy link
Contributor Author

jlaur commented Oct 11, 2025

@stefan-hoehn - maybe you have something to add here?

Copy link
Contributor

@digitaldan digitaldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lsiepel lsiepel requested a review from stefan-hoehn October 11, 2025 20:51
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@lsiepel lsiepel merged commit 8814337 into openhab:main Oct 16, 2025
3 checks passed
@lsiepel lsiepel added this to the 5.1 milestone Oct 16, 2025
@jlaur jlaur deleted the matter-readme-images branch October 17, 2025 15:57
@jlaur
Copy link
Contributor Author

jlaur commented Oct 17, 2025

This PR didn't break the images that already worked, but unfortunately it didn't fix those that don't work either.

EDIT: Sorry, there hasn't been a build yet, so will have to check again: https://ci.openhab.org/view/Documentation/

@jlaur jlaur mentioned this pull request Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants