[avmfritz] Added ThingActions for power meter device to enable/disable high polling#19488
Merged
lsiepel merged 3 commits intoopenhab:mainfrom Oct 19, 2025
Merged
Conversation
…ing intervall Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
cweitkamp
added
the
enhancement
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds ThingActions for power meter devices to enable/disable high polling for more frequent value updates. The PR also performs significant code refactoring including renaming heating mode constants and method names for better clarity.
- Added new ThingActions API for enabling/disabling high refresh polling on power meter devices
- Refactored heating mode constants from
MODE_*toHEATING_MODE_*for better naming consistency - Renamed power meter related methods from
getPowermeter()togetPowerMeter()throughout the codebase
Reviewed Changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| AVMFritzPowerMeterActions.java | New ThingActions class providing enable/disable high refresh polling functionality |
| AVMFritzPowerMeterDeviceHandler.java | New handler for power meter devices with polling capabilities |
| AVMFritzBindingConstants.java | Added constants for power meter thing types and GET_ENERGY_STATS action |
| HeatingModel.java | Updated to use new HEATING_MODE_* constants |
| Various test files | Updated method calls and constant references to match refactored names |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...z/src/main/java/org/openhab/binding/avmfritz/internal/actions/AVMFritzPowerMeterActions.java
Outdated
Show resolved
Hide resolved
...itz/src/main/java/org/openhab/binding/avmfritz/internal/dto/templates/TemplateListModel.java
Show resolved
Hide resolved
...fritz/src/main/java/org/openhab/binding/avmfritz/internal/dto/templates/DeviceListModel.java
Show resolved
Hide resolved
...inding.avmfritz/src/main/java/org/openhab/binding/avmfritz/internal/dto/DeviceListModel.java
Show resolved
Hide resolved
...main/java/org/openhab/binding/avmfritz/internal/handler/AVMFritzPowerMeterDeviceHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
lsiepel
requested changes
Oct 17, 2025
Contributor
lsiepel
left a comment
lsiepel
left a comment
There was a problem hiding this comment.
Also thanks for the refactoring. Just one comment. Otherwise LGTM
...fritz/src/main/java/org/openhab/binding/avmfritz/internal/AVMFritzBindingConstants.java.orig
Outdated
Show resolved
Hide resolved
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added ThingActions for power meter device to enable/disable high polling
Signed-off-by: Christoph Weitkamp github@christophweitkamp.de