Fix documentation, grammar, and spelling in bindings T#19601
Merged
jlaur merged 9 commits intoopenhab:mainfrom Jan 24, 2026
Merged
Fix documentation, grammar, and spelling in bindings T#19601jlaur merged 9 commits intoopenhab:mainfrom
jlaur merged 9 commits intoopenhab:mainfrom
Conversation
lsiepel
requested review from
a team,
JueBag,
Wolfgang1966,
kaikreuzer,
kjoglum,
marvkis,
mlobstein,
psmedley,
roieg and
weymann
as code owners
psmedley
approved these changes
Nov 1, 2025
Contributor
psmedley
left a comment
psmedley
left a comment
There was a problem hiding this comment.
Approved for teslapowerwall and teslascope - thanks for your efforts on cleaning up the docs!
Wolfgang1966
approved these changes
Nov 1, 2025
Wolfgang1966
left a comment
Wolfgang1966
left a comment
There was a problem hiding this comment.
LGTM fro tacmi. I'm impressed about all the details you found!
mlobstein
approved these changes
Nov 1, 2025
Contributor
mlobstein
left a comment
mlobstein
left a comment
There was a problem hiding this comment.
tasmotaplug, tivo LGTM
Contributor
Author
|
Build fails due to #19650 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves documentation, grammar, and spelling across multiple "T" bindings in the openHAB repository. The changes focus on consistency, clarity, and correctness of user-facing documentation and configuration files.
Key Changes
- Standardized capitalization of "Thing" when referring to openHAB Things
- Corrected common spelling errors (e.g., "LED's" → "LEDs", "wiperblade" → "wiper blade")
- Improved grammar and sentence structure throughout documentation
- Added missing parameter constraints and requirements in configuration files
- Standardized terminology (e.g., "Wi-Fi" consistently used instead of mixed forms)
Reviewed changes
Copilot reviewed 44 out of 44 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| bundles/org.openhab.binding.tuya/src/main/resources/OH-INF/thing/thing-types.xml | Fixed grammar in IR code descriptions and channel configuration descriptions |
| bundles/org.openhab.binding.tuya/src/main/resources/OH-INF/i18n/tuya.properties | Corrected grammar, removed duplicate entries, reorganized content, fixed spacing in command options |
| bundles/org.openhab.binding.tuya/src/main/resources/OH-INF/config/config.xml | Added required="true" to min/max parameters for dimmer, number, and quantity configurations |
| bundles/org.openhab.binding.tuya/README.md | Extensive grammar and spelling fixes, standardized "Thing" capitalization, improved clarity throughout |
| bundles/org.openhab.binding.tradfri/src/main/resources/OH-INF/thing/thing-types.xml | Fixed apostrophe in "LED's" → "LEDs", added unitHint and improved state patterns for time channels |
| bundles/org.openhab.binding.tradfri/src/main/resources/OH-INF/i18n/tradfri.properties | Corrected "LED's" → "LEDs" |
| bundles/org.openhab.binding.tradfri/README.md | Grammar improvements, fixed "thing" → "Thing" capitalization, corrected "matrixes" → "matrices" |
| bundles/org.openhab.binding.tr064/src/main/resources/OH-INF/i18n/tr064.properties | Reorganized profile configuration, improved descriptions for phonebook parameters |
| bundles/org.openhab.binding.tr064/README.md | Grammar and formatting improvements, standardized "Thing" capitalization, improved clarity |
| bundles/org.openhab.binding.tplinksmarthome/README.md | Capitalized "Thing" references consistently |
| bundles/org.openhab.binding.touchwand/src/main/resources/OH-INF/thing/bridge.xml | Added required="true" to username parameter |
| bundles/org.openhab.binding.touchwand/README.md | Fixed product name capitalization, grammar corrections, improved descriptions |
| bundles/org.openhab.binding.tivo/src/main/resources/OH-INF/thing/thing-types.xml | Fixed malformed description text "{ReadOnly)" → "(read-only)" |
| bundles/org.openhab.binding.tivo/src/main/resources/OH-INF/i18n/tivo.properties | Fixed malformed description text "{ReadOnly)" → "(read-only)" |
| bundles/org.openhab.binding.tivo/README.md | Grammar improvements, standardized "Thing" capitalization |
| bundles/org.openhab.binding.tibber/src/main/resources/OH-INF/thing/thing-types.xml | Updated label formatting, added min/max constraints, improved descriptions |
| bundles/org.openhab.binding.tibber/src/main/resources/OH-INF/thing/price-group.xml | Fixed "Informations" → "Information", improved description clarity |
| bundles/org.openhab.binding.tibber/src/main/resources/OH-INF/thing/channel-types.xml | Improved descriptions, better formatting for multi-line descriptions |
| bundles/org.openhab.binding.tibber/src/main/resources/OH-INF/i18n/tibber.properties | Grammar and consistency improvements across all descriptions |
| bundles/org.openhab.binding.tibber/src/main/resources/OH-INF/addon/addon.xml | Improved description formatting |
| bundles/org.openhab.binding.tibber/README.md | Extensive improvements to grammar, clarity, and consistency throughout documentation |
| bundles/org.openhab.binding.teslascope/src/main/resources/OH-INF/thing/thing-types.xml | Fixed spelling "wiperblade" → "wiper blade", improved interval descriptions |
| bundles/org.openhab.binding.teslascope/src/main/resources/OH-INF/i18n/teslascope.properties | Updated thing labels, improved descriptions |
| bundles/org.openhab.binding.teslascope/README.md | Capitalized "Thing" consistently |
| bundles/org.openhab.binding.teslapowerwall/src/main/resources/OH-INF/thing/thing-types.xml | Fixed spelling "emported" → "imported", corrected "13.5kW" → "13.5 kWh" |
| bundles/org.openhab.binding.teslapowerwall/src/main/resources/OH-INF/i18n/teslapowerwall.properties | Fixed spelling and unit corrections |
| bundles/org.openhab.binding.teslapowerwall/README.md | Grammar corrections, fixed item reference typo |
| bundles/org.openhab.binding.tellstick/README.md | Grammar improvements, corrected "thing" → "Thing", fixed various spelling errors |
| bundles/org.openhab.binding.telegram/src/main/resources/OH-INF/thing/thing-types.xml | Fixed grammar "send" → "sent", "give" → "given", corrected possessive forms |
| bundles/org.openhab.binding.telegram/src/main/resources/OH-INF/i18n/telegram.properties | Applied same grammar corrections as XML file |
| bundles/org.openhab.binding.telegram/README.md | Capitalized "Thing" consistently |
| bundles/org.openhab.binding.tasmotaplug/README.md | Capitalized "Thing", fixed "depends of on" → "depends on" |
| bundles/org.openhab.binding.tapocontrol/src/main/resources/OH-INF/i18n/tapocontrol.properties | Added new thing types, improved grammar and clarity in all descriptions |
| bundles/org.openhab.binding.tapocontrol/src/main/resources/OH-INF/config/bridgeconfig.xml | Improved descriptions for consistency and clarity |
| bundles/org.openhab.binding.tapocontrol/README.md | Extensive grammar and spelling improvements, standardized "Thing" and "Wi-Fi" usage |
| bundles/org.openhab.binding.tankerkoenig/src/main/resources/OH-INF/thing/station.xml | Capitalized channel descriptions |
| bundles/org.openhab.binding.tankerkoenig/src/main/resources/OH-INF/i18n/tankerkoenig.properties | Capitalized descriptions to match XML |
| bundles/org.openhab.binding.tankerkoenig/README.md | Grammar improvements, standardized capitalization, improved clarity |
| bundles/org.openhab.binding.tado/README.md | Capitalized "Thing" consistently |
| bundles/org.openhab.binding.tacmi/src/main/resources/OH-INF/thing/thing-types.xml | Fixed "Host name of IP" → "Host name or IP", corrected "OpenHAB" → "openHAB", improved descriptions, fixed min value for nodeId |
| bundles/org.openhab.binding.tacmi/src/main/resources/OH-INF/thing/bridge.xml | Corrected "OpenHAB" → "openHAB" |
| bundles/org.openhab.binding.tacmi/src/main/resources/OH-INF/i18n/tacmi.properties | Applied same corrections, improved update policy description, fixed "On-Update" → "On-Change" |
| bundles/org.openhab.binding.tacmi/src/main/resources/OH-INF/config/config.xml | Improved description clarity, corrected "On-Update" → "On-Change" |
| bundles/org.openhab.binding.tacmi/README.md | Extensive grammar improvements, corrected "OpenHAB" → "openHAB", fixed spelling errors, improved clarity throughout |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lsiepel
requested review from
kgoderis,
nokyyz and
olivierkeke
as code owners
lsiepel
added
rebuild
lsiepel
force-pushed
the
spelling-Tplus
branch
from
a63a320 to
d78626b
Compare
Contributor
Author
|
(force push due to tado conflict.) |
Contributor
Author
|
(force push due to tapocontrol and somfylink conflict.) @jlaur i like to add a commit once this is reviewed that makes sure a |
lsiepel
force-pushed
the
spelling-Tplus
branch
from
d78626b to
7f6a864
Compare
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
lsiepel
force-pushed
the
spelling-Tplus
branch
from
7f6a864 to
4bc42d3
Compare
jlaur
requested changes
Jan 21, 2026
Contributor
jlaur
left a comment
jlaur
left a comment
There was a problem hiding this comment.
Thanks! I'm through and posted a few comments.
bundles/org.openhab.binding.tapocontrol/src/main/resources/OH-INF/config/bridgeconfig.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.tradfri/src/main/resources/OH-INF/thing/thing-types.xml
Show resolved
Hide resolved
|
|
||
| <channel-type id="filter-uptime"> | ||
| <item-type>Number:Time</item-type> | ||
| <item-type unitHint="min">Number:Time</item-type> |
Contributor
Author
There was a problem hiding this comment.
Changed it to days, as week seems a wide range.
bundles/org.openhab.binding.tradfri/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.tuya/src/main/resources/OH-INF/i18n/tuya.properties
Show resolved
Hide resolved
bundles/org.openhab.binding.tuya/src/main/resources/OH-INF/config/config.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
jlaur
reviewed
Jan 21, 2026
Contributor
jlaur
left a comment
jlaur
left a comment
There was a problem hiding this comment.
Almost there. These changes are a bit more than documentation and might require a small test. Added some comments mostly as questions.
bundles/org.openhab.binding.tradfri/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.tradfri/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
…thing/thing-types.xml Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: lsiepel <leosiepel@gmail.com>
…thing/thing-types.xml Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: lsiepel <leosiepel@gmail.com>
jlaur
reviewed
Jan 24, 2026
bundles/org.openhab.binding.tradfri/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
…thing/thing-types.xml Co-authored-by: Jacob Laursen <jacob-github@vindvejr.dk> Signed-off-by: lsiepel <leosiepel@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.