Skip to content

Fix documentation, grammar, and spelling in bindings T #19601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jlaur merged 9 commits into from
Jan 24, 2026
Merged

Fix documentation, grammar, and spelling in bindings T #19601

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5a08ac3
T-bindings
lsiepel Nov 1, 2025
c999d2e
Spotless
lsiepel Nov 23, 2025
f74fbb5
Fix thing => Thing
lsiepel Dec 7, 2025
4bc42d3
Fix table alignment
lsiepel Dec 28, 2025
5090ffb
Review comments
lsiepel Jan 21, 2026
66720f7
Align tables
lsiepel Jan 21, 2026
950a0fd
Update bundles/org.openhab.binding.tradfri/src/main/resources/OH-INF/…
lsiepel Jan 23, 2026
d071bac
Update bundles/org.openhab.binding.tradfri/src/main/resources/OH-INF/…
lsiepel Jan 23, 2026
444f09b
Update bundles/org.openhab.binding.tradfri/src/main/resources/OH-INF/…
lsiepel Jan 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
116 changes: 58 additions & 58 deletions bundles/org.openhab.binding.tacmi/README.md
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions bundles/org.openhab.binding.tacmi/src/main/resources/OH-INF/config/config.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@
<config-description uri="channel-type:tacmi:schemaApiDefaults">
<parameter name="updatePolicy" type="integer" min="0" max="2">
<label>Update Policy</label>
<description>Update policy for this channel. Default means "On-Change" for channels that can be modified and
"On-Fetch" for read-only channels.</description>
<description>Update policy for this channel. Default means "On-Fetch" for read-only channels and "On-Change" for
channels that can be modified.</description>
<default>0</default>
<options>
<option value="0">Default</option>
<option value="1">On-Fetch</option>
<option value="2">On-Update</option>
<option value="2">On-Change</option>
</options>
</parameter>
</config-description>
Expand Down
13 changes: 7 additions & 6 deletions bundles/org.openhab.binding.tacmi/src/main/resources/OH-INF/i18n/tacmi.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,18 +12,18 @@ thing-type.tacmi.cmiJSON.description = Communication via the "JSONAPI" on a "Tec
thing-type.tacmi.cmiSchema.label = TA C.M.I. Schema API Connection
thing-type.tacmi.cmiSchema.description = Communication to a special "API" schema page on a "Technische Alternative C.M.I. Control and Monitoring Interface"
thing-type.tacmi.coe-bridge.label = TA C.M.I. CoE Bridge
thing-type.tacmi.coe-bridge.description = This bridge opens the CoE-UDP Port 5441 on OpenHAB for communication with "Technische Alternative C.M.I."
thing-type.tacmi.coe-bridge.description = This bridge opens the CoE-UDP Port 5441 on openHAB for communication with "Technische Alternative C.M.I."

# thing types config

thing-type.config.tacmi.cmi.host.label = C.M.I. IP Address
thing-type.config.tacmi.cmi.host.description = Host name of IP address of the CMI
thing-type.config.tacmi.cmi.host.description = Host name or IP address of the C.M.I.
thing-type.config.tacmi.cmi.node.label = Node
thing-type.config.tacmi.cmi.node.description = The CoE / CAN Node number openHAB should represent
thing-type.config.tacmi.cmiJSON.host.label = C.M.I. IP Address
thing-type.config.tacmi.cmiJSON.host.description = Host name or IP address of the C.M.I.
thing-type.config.tacmi.cmiJSON.nodeId.label = Node Id
thing-type.config.tacmi.cmiJSON.nodeId.description = The node ID of the device you want to monitor (CMI → CAN-Bus)
thing-type.config.tacmi.cmiJSON.nodeId.description = The node ID of the device you want to monitor (C.M.I. → CAN-Bus)
thing-type.config.tacmi.cmiJSON.params.label = API-Parameters
thing-type.config.tacmi.cmiJSON.params.description = The params to query. E.g. I,O,Sg (See the <a href="https://wiki.ta.co.at/C.M.I._JSON-API">API documentation</a> for details)<br /> Possible options are: Inputs (I), Outputs (O), General (Sg), Logging Analog (La), Logging Digital (Ld)
thing-type.config.tacmi.cmiJSON.password.label = Password
Expand All @@ -42,6 +42,7 @@ thing-type.config.tacmi.cmiSchema.schemaId.label = API Schema Id
thing-type.config.tacmi.cmiSchema.schemaId.description = ID of the schema API page
thing-type.config.tacmi.cmiSchema.username.label = Username
thing-type.config.tacmi.cmiSchema.username.description = Username for authentication on the C.M.I.

# channel types

channel-type.tacmi.coe-analog-in.label = Analog Input Channel (C.M.I. -> OH)
Expand All @@ -51,7 +52,7 @@ channel-type.tacmi.coe-analog-out.description = An Analog Channel sent to the C.
channel-type.tacmi.coe-digital-in.label = Digital Input (C.M.I. -> OH)
channel-type.tacmi.coe-digital-in.description = A digital channel sent from C.M.I. to openHAB
channel-type.tacmi.coe-digital-out.label = Digital Output (OH -> C.M.I.)
channel-type.tacmi.coe-digital-out.description = A digital channel sent from OpenHAB to C.M.I.
channel-type.tacmi.coe-digital-out.description = A digital channel sent from openHAB to C.M.I.
channel-type.tacmi.schema-date-time-ro.label = Time Value
channel-type.tacmi.schema-date-time-ro.description = A time read from C.M.I. - Only the time is supplied, the date part is set to the current day.
channel-type.tacmi.schema-numeric-ro.label = Value
Expand Down Expand Up @@ -102,7 +103,7 @@ channel-type.config.tacmi.coe-digital-out.initialValue.description = Initial val
channel-type.config.tacmi.coe-digital-out.output.label = Output
channel-type.config.tacmi.coe-digital-out.output.description = Network Output
channel-type.config.tacmi.schemaApiDefaults.updatePolicy.label = Update Policy
channel-type.config.tacmi.schemaApiDefaults.updatePolicy.description = Update policy for this channel. Default means "On-Change" for channels that can be modified and "On-Fetch" for read-only channels.
channel-type.config.tacmi.schemaApiDefaults.updatePolicy.description = Update policy for this channel. Default means "On-Fetch" for read-only channels and "On-Change" for channels that can be modified.
channel-type.config.tacmi.schemaApiDefaults.updatePolicy.option.0 = Default
channel-type.config.tacmi.schemaApiDefaults.updatePolicy.option.1 = On-Fetch
channel-type.config.tacmi.schemaApiDefaults.updatePolicy.option.2 = On-Update
channel-type.config.tacmi.schemaApiDefaults.updatePolicy.option.2 = On-Change
2 changes: 1 addition & 1 deletion bundles/org.openhab.binding.tacmi/src/main/resources/OH-INF/thing/bridge.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@

<bridge-type id="coe-bridge">
<label>TA C.M.I. CoE Bridge</label>
<description>This bridge opens the CoE-UDP Port 5441 on OpenHAB for communication with "Technische Alternative C.M.I."</description>
<description>This bridge opens the CoE-UDP Port 5441 on openHAB for communication with "Technische Alternative C.M.I."</description>
</bridge-type>
</thing:thing-descriptions>
10 changes: 5 additions & 5 deletions bundles/org.openhab.binding.tacmi/src/main/resources/OH-INF/thing/thing-types.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
<config-description>
<parameter name="host" type="text" required="true">
<label>C.M.I. IP Address</label>
<description>Host name of IP address of the CMI</description>
<description>Host name or IP address of the C.M.I.</description>
<context>network-address</context>
</parameter>
<parameter name="node" type="integer" min="1" max="62" required="true">
Expand Down Expand Up @@ -46,7 +46,7 @@
<channel-type id="coe-digital-out">
<item-type>Switch</item-type>
<label>Digital Output (OH -> C.M.I.)</label>
<description>A digital channel sent from OpenHAB to C.M.I.</description>
<description>A digital channel sent from openHAB to C.M.I.</description>
<tags>
<tag>Switch</tag>
</tags>
Expand Down Expand Up @@ -80,7 +80,7 @@
<channel-type id="coe-analog-out">
<item-type>Number</item-type>
<label>Analog Output Channel (OH -> C.M.I.)</label>
<description>A Analog Channel sent to the C.M.I.</description>
<description>An Analog Channel sent to the C.M.I.</description>
<tags>
<tag>Control</tag>
</tags>
Expand Down Expand Up @@ -227,9 +227,9 @@
<description>Password for authentication on the C.M.I.</description>
<context>password</context>
</parameter>
<parameter name="nodeId" type="integer" required="true" min="0">
<parameter name="nodeId" type="integer" required="true" min="1">
<label>Node Id</label>
<description>The node ID of the device you want to monitor (CMI → CAN-Bus)</description>
<description>The node ID of the device you want to monitor (C.M.I. → CAN-Bus)</description>
</parameter>
<parameter name="params" type="text">
<label>API-Parameters</label>
Expand Down
Loading
Loading