Skip to content

Comments

[shelly] Remove duplicated and misspelled DTO fields#20087

Merged
lsiepel merged 1 commit intoopenhab:mainfrom
jlaur:shelly-api-typos
Jan 17, 2026
Merged

[shelly] Remove duplicated and misspelled DTO fields#20087
lsiepel merged 1 commit intoopenhab:mainfrom
jlaur:shelly-api-typos

Conversation

@jlaur
Copy link
Contributor

@jlaur jlaur commented Jan 17, 2026

Follow-up to #20084 (comment)

According to the documentation:

Attribute Type Description
dark_threshold number Illumination level threshold for dark condition.
twilight_threshold number Illumination level threshold for twilight condition.

The fields are currently unused, but fixing them now can avoid future issues.

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur requested a review from markus7017 as a code owner January 17, 2026 14:31
@jlaur jlaur changed the title [shelly] Remove duplicated and misspelled fields [shelly] Remove duplicated and misspelled DTO fields Jan 17, 2026
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

Let's not classify this as a bug as the field was not used yet.

@lsiepel lsiepel merged commit ae079c6 into openhab:main Jan 17, 2026
2 checks passed
@lsiepel lsiepel added this to the 5.2 milestone Jan 17, 2026
@jlaur jlaur deleted the shelly-api-typos branch January 17, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants