Skip to content

[shelly] Remove duplicated and misspelled DTO fields #20087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lsiepel merged 1 commit into from
Jan 17, 2026
Merged

[shelly] Remove duplicated and misspelled DTO fields #20087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions ...ding.shelly/src/main/java/org/openhab/binding/shelly/internal/api1/Shelly1ApiJsonDTO.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,10 +685,6 @@ public static class ShellySettingsGlobal {
public Boolean rainSensor; // Flood: true=in rain mode

// FW 1.5.7: Door Window
@SerializedName("dark_treshold")
public Integer darkTreshold; // Illumination definition for "dark" in lux
@SerializedName("twilight_treshold")
public Integer twiLightTreshold; // Illumination definition for "twilight" in lux
@SerializedName("dark_url")
public String darkUrl; // URL to report to when luminance <= dark_threshold
@SerializedName("twilight_url")
Expand Down Expand Up @@ -717,8 +713,14 @@ public static class ShellySettingsGlobal {
public ShellyMotionSettings motion;
@SerializedName("tamper_sensitivity")
public Integer tamperSensitivity;
/**
* Illumination level threshold for dark condition.
*/
@SerializedName("dark_threshold")
public Integer darkThreshold;
/**
* Illumination level threshold for twilight condition.
*/
@SerializedName("twilight_threshold")
public Integer twilightThreshold;

Expand Down
2 changes: 1 addition & 1 deletion ...ding.shelly/src/main/java/org/openhab/binding/shelly/internal/api2/Shelly2ApiJsonDTO.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ public class Shelly2DevConfigInput {
@SerializedName("factory_reset")
public Boolean factoryReset;
@SerializedName("report_thr")
public Double reportTreshold; // only for type analog
public Double reportThreshold; // only for type analog
}

public class Shelly2DevConfigSwitch {
Expand Down