Conversation
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Signed-off-by: Gavinok <34443260+Gavinok@users.noreply.github.com>
Pull Request Test Coverage Report for Build 16483119139Details
💛 - Coveralls |
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com> 1. Updated timestamps in models to use UTC for consistency across the application. 2. Added comprehensive tests for ACA-Py webhook handler, covering various scenarios including connection status changes, presentation request handling, and error reporting. 3. Introduced new dependencies in the `pyproject.toml` for HTTP handling in tests. 4. Improved mocking strategies in test cases for better isolation and reliability. These changes ensure better adherence to time standards and robustness in handling connection-based verification's and related testing.
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Gavinok
force-pushed
the
connection-based-verification
branch
from
834c9ce to
c1eb8ec
Compare
… auth_sessions Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Gavinok
force-pushed
the
connection-based-verification
branch
from
5937a76 to
7a5d3ba
Compare
| export INVITATION_LABEL=${INVITATION_LABEL:-"VC-AuthN"} | ||
| export SET_NON_REVOKED="True" | ||
| export USE_OOB_LOCAL_DID_SERVICE=${USE_OOB_LOCAL_DID_SERVICE:-"true"} | ||
| export USE_CONNECTION_BASED_VERIFICATION=${USE_CONNECTION_BASED_VERIFICATION:-"true"} |
There was a problem hiding this comment.
Should this be in the main docker-compose yaml too?
There was a problem hiding this comment.
I should have spotted this by testing oob again after implementing connections. Thanks for catching that
There was a problem hiding this comment.
This may still need to be added to docker-compose - the diff is not showing changes on that file
|
@Gavinok any weird behavior on yours with QR expiry? Screen.Recording.2025-07-21.222112.mp4I'm not sure if related to any of the changes in this PR but worth a check. Actually I see the expiry time wierdly set minutes in the past from when I created it 
|
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com> - Removed commented-out code for the depreciated create_invitation method - Changed comments in the acapy_handler and oidc router modules to remove "NEW" indicators for clarification.
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com> - Removed the hardcoded "pending-" prefix from the session ID lookup when searching by `pres_exch_id` in `acapy_handler.py`, allowing for more flexible ID matching. - Added a check in `oidc.py` to raise an HTTP 500 error if the invitation message ID is missing, ensuring proper error handling and clearer diagnostics when creating an OOB invitation message.
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
…and pyproject.toml Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com> - Removed 'httpx' packages from pyproject.toml as they were not needed.
esune
left a comment
esune
left a comment
There was a problem hiding this comment.
I flagged a super minor change - using debug for a couple of log statements to avoid polluting logs in regular mode with information that is not essential.
Other than that changes look good - tested locally as well and verified connection is created with BC Wallet and deleted when interaction ends. Excellent work @Gavinok !
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
loneil
left a comment
loneil
left a comment
There was a problem hiding this comment.
Need to sort the expiry thing
#802 (comment)
I tried on main and it's working with the configured time but switching to this branch is instant-expiring (unless I'm doing somethng wierd on local)
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
|
@loneil Resolved the expiry issue. Just had a timezone inconsistancy it seems. I have all the timestamps now created with UTC for consistancy and that seems to have resolved it |
|
@Gavinok behavior is working ok but see this error throwing out every second |
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
esune
left a comment
esune
left a comment
There was a problem hiding this comment.
New changes look goo, tested both in connection-less and short-lived mode and things seem to work as expected.
The USE_CONNECTION_BASED_VERIFICATION flag is not being set in docker-compose.yaml though, I added it manually for testing, but we should have it referenced like other variables for clarity/consistency.
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
esune
left a comment
esune
left a comment
There was a problem hiding this comment.
LGTM 👍🏻
Next step is updating the chart to support the new configurations (will log separate issue).
loneil
left a comment
loneil
left a comment
There was a problem hiding this comment.
Think it's all good now, not getting errors logged out. Also tested deep link and it worked ok.
4 participants
This PR resolves #513
The current implementation focuses on ephemeral connections as
specified in the plans, with connection-based verification made
optional via the
USE_CONNECTION_BASED_VERIFICATIONconfigurationflag.
Key Components Added:
USE_CONNECTION_BASED_VERIFICATIONsetting (defaults to True)USE_CONNECTION_BASED_VERIFICATIONflagEnabled connection-based verification by default
Added environment variable support
Current Status
The implementation provides a foundation for connection-based
verification that can be toggled on/off, focusing on the ephemeral
connection model outlined in the plans while maintaining backward
compatibility with the existing QR code flow.