-
Notifications
You must be signed in to change notification settings - Fork 76
Connection based verification #802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
9f1765d
Initial POC of connection based verification
Gavinok 6c01f3b
Applied black formatting
Gavinok 0d65fa1
Removed assertion to ensure we didn't use oob
Gavinok aeb2ef9
Merge branch 'main' into connection-based-verification
Gavinok bdd5fc5
Added problem reports on failed connections
Gavinok ebc1ae3
Add connection verification testing
Gavinok c1eb8ec
Improve test coverage
Gavinok 7a5d3ba
Use multi_use keyword rather than ephemeral and only delete multi_use…
Gavinok 75c00ea
Remove NEW comments and removed depreciated create_invitation
Gavinok 31d5aec
Fix: removed "pending-" prefix and error reporting with invi_msg_id
Gavinok c63cd3f
Removed pointless "assert False" that was left over from testing
Gavinok 3357040
Remove unnecessary dependencies and group allocations in poetry.lock …
Gavinok e9c0029
Restore httpx dependancy
Gavinok 23f4e53
Change logging type
Gavinok 6c936d9
Merge branch 'main' into connection-based-verification
Gavinok 74e5007
Corrected inconsistent expiry and creation timestamps
Gavinok 2006162
Handle timezone aware comparison datetimes
Gavinok 376d246
Add USE_CONNECTION_BASED_VERIFICATION to docker compose
Gavinok File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| """AuthSession tests package.""" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be in the main docker-compose yaml too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should have spotted this by testing oob again after implementing connections. Thanks for catching that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may still need to be added to docker-compose - the diff is not showing changes on that file