Add Bootstrap script to store a credential in the vc-auth agent#917
Add Bootstrap script to store a credential in the vc-auth agent#917esune merged 7 commits intoopenwallet-foundation:mainfrom
Conversation
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Pull Request Test Coverage Report for Build 19902614254Details
💛 - Coveralls |
esune
left a comment
There was a problem hiding this comment.
This looks great, thanks @Gavinok - only a comment about the schema name needing to be more deterministic and wondering if we should split the issuer compose configuration to a separate file (i.e.: the ngrok compose file) in order to reduce the number of services required by default to run VC-AuthN locally 🤔
|
@esune On the topic of seperating these into seperate files there shouldn't be any need to run the issuer if it isn't used. By default the issuer is not started unless the |
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
esune
left a comment
There was a problem hiding this comment.
Nit.: let's update the agent image to a recent one (probably good to do also for the VC-AuthN verifier agent) and then we're good to go
Co-authored-by: Emiliano Suñé <emiliano.sune@gmail.com> Signed-off-by: Gavinok <34443260+Gavinok@users.noreply.github.com>
This PR resolves #900
Here we add a script to store a credential in vc-authn