Skip to content

Add Bootstrap script to store a credential in the vc-auth agent#917

Merged
esune merged 7 commits intoopenwallet-foundation:mainfrom
Gavinok:bootstrap-credential
Dec 4, 2025
Merged

Add Bootstrap script to store a credential in the vc-auth agent#917
esune merged 7 commits intoopenwallet-foundation:mainfrom
Gavinok:bootstrap-credential

Conversation

@Gavinok
Copy link
Contributor

@Gavinok Gavinok commented Nov 26, 2025

This PR resolves #900

Here we add a script to store a credential in vc-authn

Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
@Gavinok Gavinok requested a review from esune November 26, 2025 20:24
@coveralls
Copy link

coveralls commented Nov 26, 2025

Pull Request Test Coverage Report for Build 19902614254

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.716%

Totals Coverage Status
Change from base Build 19825684003: 0.0%
Covered Lines: 1928
Relevant Lines: 2198

💛 - Coveralls

Copy link
Member

@esune esune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks @Gavinok - only a comment about the schema name needing to be more deterministic and wondering if we should split the issuer compose configuration to a separate file (i.e.: the ngrok compose file) in order to reduce the number of services required by default to run VC-AuthN locally 🤔

@Gavinok
Copy link
Contributor Author

Gavinok commented Dec 2, 2025

@esune On the topic of seperating these into seperate files there shouldn't be any need to run the issuer if it isn't used. By default the issuer is not started unless the ./manage bootstrap is run. I don't see any reason not to split this off into a new docker compose though since there isn't any direct connection.

Gavinok and others added 3 commits December 2, 2025 09:31
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
@Gavinok Gavinok requested review from esune and loneil December 2, 2025 18:38
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
@Gavinok Gavinok mentioned this pull request Dec 2, 2025
Copy link
Member

@esune esune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit.: let's update the agent image to a recent one (probably good to do also for the VC-AuthN verifier agent) and then we're good to go

Co-authored-by: Emiliano Suñé <emiliano.sune@gmail.com>
Signed-off-by: Gavinok <34443260+Gavinok@users.noreply.github.com>
Copy link
Member

@esune esune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@esune esune merged commit cedba81 into openwallet-foundation:main Dec 4, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add bootstrap script for issuing trusted verifier credential

3 participants