Skip to content

IFC-1305 Remove permission identifier custom code#8330

Draft
gmazoyer wants to merge 5 commits intodevelopfrom
gma-20260206-ifc1305-bis
Draft

IFC-1305 Remove permission identifier custom code#8330
gmazoyer wants to merge 5 commits intodevelopfrom
gma-20260206-ifc1305-bis

Conversation

@gmazoyer
Copy link
Contributor

@gmazoyer gmazoyer commented Feb 6, 2026

This change cleans up the custom code we used to have to generate permission identifiers. These are now replaced by display labels (brought by #8039).

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 6, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added group/backend Issue related to the backend (API Server, Git Agent) group/frontend Issue related to the frontend (React) labels Feb 6, 2026
@gmazoyer gmazoyer force-pushed the gma-20260206-ifc1305-bis branch from d52db84 to ee586ce Compare February 6, 2026 10:29
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 6, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing gma-20260206-ifc1305-bis (903ef85) with develop (e64e399)

Summary

✅ 12 untouched benchmarks

optional=True,
allow_override=AllowOverrideType.NONE,
deprecation="Use permission display_label instead",
),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a migration or state=absent here for this to be removed from existing installations?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We sure do we have the backend/infrahub/core/schema/definitions/deprecated.py file for that it seems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

group/backend Issue related to the backend (API Server, Git Agent) group/frontend Issue related to the frontend (React)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants