Skip to content

fix: confusing tls connection indicator#747

Merged
levkk merged 1 commit intopgdogdev:mainfrom
bzp2010:bzp/fix-log-tls-symbol
Feb 4, 2026
Merged

fix: confusing tls connection indicator#747
levkk merged 1 commit intopgdogdev:mainfrom
bzp2010:bzp/fix-log-tls-symbol

Conversation

@bzp2010
Copy link
Contributor

@bzp2010 bzp2010 commented Feb 4, 2026

Currently, the log uses 🔓 to indicate a TLS connection, which is confusing.
Since the lock in this icon is open, it appears inconsistent with the expression of security.

To convey security, using a locked lock icon 🔒 seems more appropriate. One piece of evidence is that the code in

info!("🔓 TLS disabled");
uses 🔓 to indicate TLS is disabled.

Regarding whether to use 🔓 as an indicator for non-TLS connections, I welcome further input.

@CLAassistant
Copy link

CLAassistant commented Feb 4, 2026

CLA assistant check
All committers have signed the CLA.

@bzp2010 bzp2010 force-pushed the bzp/fix-log-tls-symbol branch from 23b4bb3 to 9afa9f6 Compare February 4, 2026 18:33
Copy link
Collaborator

@levkk levkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now this is the kind of attention to detail we need on this project. Thank you!

@levkk levkk merged commit f9015c0 into pgdogdev:main Feb 4, 2026
6 checks passed
@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pgdog/src/backend/server.rs 0.00% 1 Missing ⚠️
pgdog/src/frontend/client/mod.rs 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants