Closed
Conversation
gvwilson
added
feature
Member
|
@BSd3v is this PR in good shape in your eyes? We could go to 33.0.4 instead of sticking at 31. |
Collaborator
|
No, there a breaking changes between each major release. We should step up 31, then 32, and then support both 32 and 33. Upstream AG grid has stated that they will support 32 and 33 because there are so many changes between the 2. |
Merged
Contributor
|
Closing this in favour of #381 which implements theming along with the version bump. Thanks for the code inspiration in this PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bumps ag-grid version to 33.0.4
I would also like to add a
themeparameter to theAgGridcomponent as well, since this is the preferred way to style the grid now. Can I do that in this PR as well or is it better to save for a separate PR?