Feature: AG Grid 33

[KoolADE85]

This PR upgrades AG Grid to version 33.

[AnnMarieW]

Hi @KoolADE85

I think there was a discussion about AG Grid supporting V32 for the long term because there are so many breaking changes going from v32 to v33. However, going from v33 to v34 does not have any breaking changes, so it might actually be better to do v34 and skip v33. https://www.ag-grid.com/react-data-grid/upgrading-to-ag-grid-34/

This won't have a big impact on our docs because most of the new features are for Enterprise and they aren't in the dash-docs.

[KoolADE85]

Hi @KoolADE85

I think there was a discussion about AG Grid supporting V32 for the long term because there are so many breaking changes going from v32 to v33. However, going from v33 to v34 does not have any breaking changes, so it might actually be better to do v34 and skip v33. https://www.ag-grid.com/react-data-grid/upgrading-to-ag-grid-34/

This won't have a big impact on our docs because most of the new features are for Enterprise and they aren't in the dash-docs.

Good call! I have some test failures around filters when I use v34. I'm going to investigate whether it's the test or the component itself that needs updating.

[BSd3v]

Before we do this, I need we need to branch v32 from main.

[BSd3v]

Also, we should look at this, if this PR is good, should probably do theirs. :)

#355

[BSd3v]

Should make sure there is a way to set the theme to legacy though. So that people can opt for not having to create the theme.

[KoolADE85]

Should make sure there is a way to set the theme to legacy though. So that people can opt for not having to create the theme.

OK, this gets a little tricky since AG Grid doesn't support importing legacy theme CSS files (as we were previously) AND setting a modern theme object.

So in my update, I propose that anyone who wants to keep using a legacy CSS theme, to import the CSS by hand (we won't automatically import, for example, ag-grid.css. An example of this is in tests/examples/themes_legacy.py.

Our codebase going forward, would support AG Grid's modern theme system by default. See tests/examples/themes.py.

This approach seems right because, in case of any errors/warnings, the message that AG Grid outputs in the console matches what users would need to do to their dash app in order to get the grid looking right.

[BSd3v]

Should make sure there is a way to set the theme to legacy though. So that people can opt for not having to create the theme.

OK, this gets a little tricky since AG Grid doesn't support importing legacy theme CSS files (as we were previously) AND setting a modern theme object.

So in my update, I propose that anyone who wants to keep using a legacy CSS theme, to import the CSS by hand (we won't automatically import, for example, ag-grid.css. An example of this is in tests/examples/themes_legacy.py.

Our codebase going forward, would support AG Grid's modern theme system by default. See tests/examples/themes.py.

This approach seems right because, in case of any errors/warnings, the message that AG Grid outputs in the console matches what users would need to do to their dash app in order to get the grid looking right.

We can still support these files and not import them directly into the grid the same way. There are a couple of repos that do this in order to make it easier to import these files that are otherwise dependencies to make the package load properly.

[KoolADE85]

Alright, I'm giving this a try: lazy load the css for legacy themes if the user has specified a className (and no theme). Otherwise, default to AG Grid's modern theme system.
There's quite a bit of extra code to keep this backwards-compatible API, but it does achieve the goal of allowing users to upgrade without needing to refactor their theming.
What do you think?

[BSd3v]

Also, we should look at this, if this PR is good, should probably do theirs. :)

#355

It seems like #355 is covered by this current PR, with a couple of other features.

[KoolADE85]

Also, we should look at this, if this PR is good, should probably do theirs. :)
#355

It seems like #355 is covered by this current PR, with a couple of other features.

Yes, I think that one can be closed in favour of this one - we have theme support now here, plus latest patch release of 33.

[BSd3v]

LGTM 💃