Implement Thai language support with combining character handling#6671
Closed
Faelayis wants to merge 3 commits intoppy:masterfrom
Closed
Implement Thai language support with combining character handling#6671Faelayis wants to merge 3 commits intoppy:masterfrom
Faelayis wants to merge 3 commits intoppy:masterfrom
Conversation
The issue occurred because the renderer placed Thai combining glyphs incorrectly, causing overlapping when multiple diacritics were stacked.
Collaborator
|
I have zero interest in merging this, this is basically attempting to start a complete new text shaping library within framework. We don't have the scope and resources for that. Next we know a Vietnamese user will come here and start complaining that Vietnamese combining characters are incorrect. In my eyes an actual scalable solution to this would to just do what everyone else is doing and incorporate harfbuzz or equivalent. Potentially combined with #6665. Maybe some other maintainer will bite. |
Contributor
|
I agree with the above, and I'm pretty sure SDL_ttf uses harfbuzz. Have suggested the library to be used in #6665. Thanks for the contribution, but let's not do it this way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issues: ppy/osu#21429
This pr introduces locale-aware handling of combining characters in text rendering, with a particular focus on Thai language support. The changes add a new
CombiningCharacterconfiguration class, update text builder classes to accept and use this configuration, and ensure that combining marks (such as those used in Thai script) are stacked and positioned correctly. The configuration is automatically applied based on the current locale.Before
masterAfter
fix/font-combining